chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1804723002: [Offline pages] Showing offline bolt on chrome custom tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1804723002: [Offline pages] Showing offline bolt on chrome custom tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index d28821809cd7f9c80b17bd2ee4323b8d46aa626e..4adf47896d5ec927810f3bd78775d6fe0aa7d30b 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -22,6 +22,16 @@

android:layout_width="@dimen/location_bar_icon_width"

android:layout_height="match_parent"

android:layout_gravity="center_vertical"

+ android:contentDescription="@string/page_info_offline_icon"

Ian Wen 2016/03/14 20:51:56 Content description is wrong.

fgorski 2016/03/15 21:09:26 Gone.

+ android:scaleType="center"

+ android:src="@drawable/offline_bolt"

+ android:visibility="gone" />

+ <ImageButton

+ android:id="@+id/offline_button"

+ style="@style/LocationBarButton"

+ android:layout_width="@dimen/location_bar_icon_width"

+ android:layout_height="match_parent"

+ android:layout_gravity="center_vertical"

android:contentDescription="@string/accessibility_toolbar_btn_site_info"

android:scaleType="center"

android:visibility="gone" />

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | no next file with comments »