Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1760)

Unified Diff: test/cctest/test-parsing.cc

Issue 1804693002: Remove --harmony-modules flag and let embedder decide when modules are used (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index ff0026d2bda1f85964df73db61aa642232e2b4c0..c881f868a0472e146f611469d9b0ff30f34f7aa1 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -1902,12 +1902,9 @@ void RunModuleParserSyncTest(const char* context_data[][2],
int always_true_len = 0,
const ParserFlag* always_false_flags = NULL,
int always_false_len = 0) {
- bool flag = i::FLAG_harmony_modules;
- i::FLAG_harmony_modules = true;
RunParserSyncTest(context_data, statement_data, result, flags, flags_len,
always_true_flags, always_true_len, always_false_flags,
always_false_len, true);
- i::FLAG_harmony_modules = flag;
}
@@ -5579,8 +5576,6 @@ TEST(ComputedPropertyNameShorthandError) {
TEST(BasicImportExportParsing) {
- i::FLAG_harmony_modules = true;
-
// clang-format off
const char* kSources[] = {
"export let x = 0;",
@@ -5679,8 +5674,6 @@ TEST(BasicImportExportParsing) {
TEST(ImportExportParsingErrors) {
- i::FLAG_harmony_modules = true;
-
// clang-format off
const char* kErrorSources[] = {
"export {",
@@ -5770,8 +5763,6 @@ TEST(ImportExportParsingErrors) {
TEST(ModuleParsingInternals) {
- i::FLAG_harmony_modules = true;
-
i::Isolate* isolate = CcTest::i_isolate();
i::Factory* factory = isolate->factory();
v8::HandleScope handles(CcTest::isolate());

Powered by Google App Engine
This is Rietveld 408576698