Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 1804643002: [interpreter] Fix label binding for unreached labels. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-test-webkit
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix label binding for unreached labels. This fixes the label binding mechanism that forwards a label to another already bound target label. For source labels that are not being reached by a jump, we should not try to patch jump sites. We still bind the source label to reflect the target position though, just in case this binding method will be used for backwards branches in the future. R=rmcilroy@chromium.org TEST=webkit/fast/js/parser-syntax-check Committed: https://crrev.com/27a9009a7c4933d632f74ce0114df9aa82e81010 Cr-Commit-Position: refs/heads/master@{#34759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-14 16:46:36 UTC) #1
rmcilroy
LGTM, thanks!
4 years, 9 months ago (2016-03-14 18:20:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804643002/1
4 years, 9 months ago (2016-03-14 18:26:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 18:28:59 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:29:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27a9009a7c4933d632f74ce0114df9aa82e81010
Cr-Commit-Position: refs/heads/master@{#34759}

Powered by Google App Engine
This is Rietveld 408576698