Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804613003: Remove unused method WebContents::CreateSwappedOutRenderView. (Closed)

Created:
4 years, 9 months ago by nasko
Modified:
4 years, 9 months ago
Reviewers:
alexmos
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused method WebContents::CreateSwappedOutRenderView. BUG=357747 Committed: https://crrev.com/ca29db355bda7920295c4e70cac5c713fbe0d943 Cr-Commit-Position: refs/heads/master@{#381031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nasko
Hey Alex, Can you review another removal of stale code? Thanks! Nasko
4 years, 9 months ago (2016-03-14 17:10:02 UTC) #2
alexmos
LGTM, happy to see this gone!
4 years, 9 months ago (2016-03-14 18:16:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804613003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804613003/1
4 years, 9 months ago (2016-03-14 18:22:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 19:04:05 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:06:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ca29db355bda7920295c4e70cac5c713fbe0d943
Cr-Commit-Position: refs/heads/master@{#381031}

Powered by Google App Engine
This is Rietveld 408576698