Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/codegen-ia32.cc

Issue 18046: Assert that, when jumping or binding a label, there is no value in the... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/jump-target-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-ia32.cc
===================================================================
--- src/codegen-ia32.cc (revision 1072)
+++ src/codegen-ia32.cc (working copy)
@@ -441,13 +441,14 @@
// Convert cc_reg_ into a boolean value.
JumpTarget loaded(this);
JumpTarget materialize_true(this);
- materialize_true.Branch(cc_reg_);
+ Condition cc = cc_reg_;
+ cc_reg_ = no_condition;
+ materialize_true.Branch(cc);
frame_->EmitPush(Immediate(Factory::false_value()));
loaded.Jump();
materialize_true.Bind();
frame_->EmitPush(Immediate(Factory::true_value()));
loaded.Bind();
- cc_reg_ = no_condition;
}
if (true_target.is_linked() || false_target.is_linked()) {
@@ -1401,8 +1402,8 @@
void CodeGenerator::Branch(bool if_true, JumpTarget* target) {
ASSERT(has_cc());
Condition cc = if_true ? cc_reg_ : NegateCondition(cc_reg_);
+ cc_reg_ = no_condition;
target->Branch(cc);
- cc_reg_ = no_condition;
}
« no previous file with comments | « no previous file | src/jump-target-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698