Assert that, when jumping or binding a label, there is no value in the...

src/jump-target-ia32.cc

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 45 matching lines @@
   ASSERT(cgen_ == NULL);
   cgen_ = cgen;
   masm_ = cgen->masm();
 }
 
 
 void JumpTarget::Jump() {
   // Precondition: there is a current frame.  There may or may not be an
   // expected frame at the label.
   ASSERT(cgen_ != NULL);
+  ASSERT(!cgen_->has_cc());
 
   VirtualFrame* current_frame = cgen_->frame();
   ASSERT(current_frame != NULL);
   ASSERT(cgen_->HasValidEntryRegisters());
 
   if (expected_frame_ == NULL) {
     current_frame->MakeMergable();
     expected_frame_ = current_frame;
     ASSERT(cgen_->HasValidEntryRegisters());
     RegisterFile ignored;
@@ skipping 17 matching lines @@
   cgen_->frame()->Push(arg);
   Jump();
 }
 
 
 void JumpTarget::Branch(Condition cc, Hint hint) {
   // Precondition: there is a current frame.  There may or may not be an
   // expected frame at the label.
   ASSERT(cgen_ != NULL);
   ASSERT(masm_ != NULL);
+  ASSERT(!cgen_->has_cc());
 
   VirtualFrame* current_frame = cgen_->frame();
   ASSERT(current_frame != NULL);
 
   if (expected_frame_ == NULL) {
     expected_frame_ = new VirtualFrame(current_frame);
     // For a branch, the frame at the fall-through basic block (not labeled)
     // does not need to be mergable, but only the other (labeled) one.  That
     // is achieved by reversing the condition and emitting the make mergable
     // code as the actual fall-through block.
@@ skipping 82 matching lines @@
   ASSERT(arg1->type() == arg1_type);
   ASSERT(!arg1->is_register() || arg1->reg().is(arg1_reg));
 }
 
 
 void JumpTarget::Call() {
   // Precondition: there is a current frame, and there is no expected frame
   // at the label.
   ASSERT(cgen_ != NULL);
   ASSERT(masm_ != NULL);
+  ASSERT(!cgen_->has_cc());
 
   VirtualFrame* current_frame = cgen_->frame();
   ASSERT(current_frame != NULL);
   ASSERT(expected_frame_ == NULL);
   ASSERT(cgen_->HasValidEntryRegisters());
 
   expected_frame_ = new VirtualFrame(current_frame);
   expected_frame_->MakeMergable();
   // Adjust the expected frame's height to account for the return address
   // pushed by the call instruction.
   expected_frame_->Adjust(1);
   ASSERT(cgen_->HasValidEntryRegisters());
 
   __ call(&label_);
   // Postcondition: there is both a current frame and an expected frame at
   // the label.  The current frame is one shorter than the one at the label
   // (which contains the return address in memory).
 }
 
 
 void JumpTarget::Bind() {
   // Precondition: there is either a current frame or an expected frame at
   // the label (and possibly both).  The label is unbound.
   ASSERT(cgen_ != NULL);
   ASSERT(masm_ != NULL);
+  ASSERT(!cgen_->has_cc());
 
   VirtualFrame* current_frame = cgen_->frame();
   ASSERT(current_frame != NULL || expected_frame_ != NULL);
   ASSERT(!label_.is_bound());
 
   if (expected_frame_ == NULL) {
     ASSERT(cgen_->HasValidEntryRegisters());
     // When a label is bound the current frame becomes the expected frame at
     // the label.  This requires the current frame to be mergable.
     current_frame->MakeMergable();
@@ skipping 17 matching lines @@
 
   __ bind(&label_);
   // Postcondition: there is both a current frame and an expected frame at
   // the label and they match.  The label is bound.
 }
 
 
 void JumpTarget::Bind(Result* arg) {
   ASSERT(cgen_ != NULL);
 
-#ifdef DEBUG
-  // We want register results at the call site to stay in the same
-  // registers.
-  bool had_entry_frame = false;
-  Result::Type arg_type;
-  Register arg_reg;
-#endif
-
   if (cgen_->has_valid_frame()) {
-#ifdef DEBUG
-    had_entry_frame = true;
-    arg_type = arg->type();
-    arg_reg = arg->is_register() ? arg->reg() : no_reg;
-#endif
     cgen_->frame()->Push(arg);
   }
   Bind();
   *arg = cgen_->frame()->Pop();
-
-  ASSERT(!had_entry_frame || arg->type() == arg_type);
-  ASSERT(!had_entry_frame || !arg->is_register() || arg->reg().is(arg_reg));
 }
 
 
 void JumpTarget::Bind(Result* arg0, Result* arg1) {
   ASSERT(cgen_ != NULL);
 
-#ifdef DEBUG
-  // We want register results at the call site to stay in the same
-  // registers.
-  bool had_entry_frame = false;
-  Result::Type arg0_type;
-  Register arg0_reg;
-  Result::Type arg1_type;
-  Register arg1_reg;
-#endif
-
   if (cgen_->frame() != NULL) {
-#ifdef DEBUG
-    had_entry_frame = true;
-    arg0_type = arg0->type();
-    arg0_reg = arg0->is_register() ? arg0->reg() : no_reg;
-    arg1_type = arg1->type();
-    arg1_reg = arg1->is_register() ? arg1->reg() : no_reg;
-#endif
     cgen_->frame()->Push(arg0);
     cgen_->frame()->Push(arg1);
   }
   Bind();
   *arg1 = cgen_->frame()->Pop();
   *arg0 = cgen_->frame()->Pop();
-
-  ASSERT(!had_entry_frame || arg0->type() == arg0_type);
-  ASSERT(!had_entry_frame ||
-         !arg0->is_register() ||
-         arg0->reg().is(arg0_reg));
-  ASSERT(!had_entry_frame || arg1->type() == arg1_type);
-  ASSERT(!had_entry_frame ||
-         !arg1->is_register() ||
-         arg1->reg().is(arg1_reg));
 }
 
 
 // -------------------------------------------------------------------------
 // ShadowTarget implementation.
 
 ShadowTarget::ShadowTarget(JumpTarget* original) {
   ASSERT(original != NULL);
   original_target_ = original;
   original_pos_ = original->label()->pos_;
@@ skipping 22 matching lines @@
 
 #ifdef DEBUG
   is_shadowing_ = false;
 #endif
 }
 
 #undef __
 
 
 } }  // namespace v8::internal