Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/wasm/test-run-wasm-64.cc

Issue 1804513002: [wasm] Int64Lowering of I64Div and I64Rem. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-64.cc
diff --git a/test/cctest/wasm/test-run-wasm-64.cc b/test/cctest/wasm/test-run-wasm-64.cc
index e9758454fc292b451e7791e4a305775ceaaf0031..ea3f7f1974e642d5680c9c00d49477398d5f0d61 100644
--- a/test/cctest/wasm/test-run-wasm-64.cc
+++ b/test/cctest/wasm/test-run-wasm-64.cc
@@ -13,6 +13,16 @@
#include "test/cctest/wasm/test-signatures.h"
#include "test/cctest/wasm/wasm-run-utils.h"
+#define CHECK_TRAP32(x) \
+ CHECK_EQ(0xdeadbeef, (bit_cast<uint32_t>(x)) & 0xFFFFFFFF)
+#define CHECK_TRAP64(x) \
+ CHECK_EQ(0xdeadbeefdeadbeef, (bit_cast<uint64_t>(x)) & 0xFFFFFFFFFFFFFFFF)
+#define CHECK_TRAP(x) CHECK_TRAP32(x)
+
+#define asi64(x) static_cast<int64_t>(x)
+
+#define asu64(x) static_cast<uint64_t>(x)
+
#define B2(a, b) kExprBlock, 2, a, b
#define B1(a) kExprBlock, 1, a
@@ -38,10 +48,10 @@
V(I64Add, true) \
V(I64Sub, false) \
V(I64Mul, false) \
- V(I64DivS, false) \
- V(I64DivU, false) \
- V(I64RemS, false) \
- V(I64RemU, false) \
+ V(I64DivS, true) \
+ V(I64DivU, true) \
+ V(I64RemS, true) \
+ V(I64RemU, true) \
V(I64And, true) \
V(I64Ior, true) \
V(I64Xor, true) \
@@ -129,9 +139,144 @@ TEST(Run_WasmI64Add) {
// kExprI64Sub:
// kExprI64Mul:
// kExprI64DivS:
+
+TEST(Run_WasmI64DivS) {
+ REQUIRE(I64DivS);
+ WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
+ BUILD(r, WASM_I64_DIVS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ FOR_INT64_INPUTS(i) {
+ FOR_INT64_INPUTS(j) {
+ if (*j == 0) {
+ CHECK_TRAP64(r.Call(*i, *j));
+ } else if (*j == -1 && *i == std::numeric_limits<int64_t>::min()) {
+ CHECK_TRAP64(r.Call(*i, *j));
+ } else {
+ CHECK_EQ(*i / *j, r.Call(*i, *j));
+ }
+ }
+ }
+}
+
+TEST(Run_WasmI64DivS_Trap) {
+ REQUIRE(I64DivS);
+ WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
+ BUILD(r, WASM_I64_DIVS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ CHECK_EQ(0, r.Call(asi64(0), asi64(100)));
+ CHECK_TRAP64(r.Call(asi64(100), asi64(0)));
+ CHECK_TRAP64(r.Call(asi64(-1001), asi64(0)));
+ CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), asi64(-1)));
+ CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), asi64(0)));
+}
+
+TEST(Run_WasmI64DivS_Byzero_Const) {
+ REQUIRE(I64DivS);
+ for (int8_t denom = -2; denom < 8; denom++) {
+ WasmRunner<int64_t> r(MachineType::Int64());
+ BUILD(r, WASM_I64_DIVS(WASM_GET_LOCAL(0), WASM_I64V_1(denom)));
+ for (int64_t val = -7; val < 8; val++) {
+ if (denom == 0) {
+ CHECK_TRAP64(r.Call(val));
+ } else {
+ CHECK_EQ(val / denom, r.Call(val));
+ }
+ }
+ }
+}
// kExprI64DivU:
+
+TEST(Run_WasmI64DivU) {
+ REQUIRE(I64DivU);
+ WasmRunner<uint64_t> r(MachineType::Uint64(), MachineType::Uint64());
+ BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ FOR_UINT64_INPUTS(i) {
+ FOR_UINT64_INPUTS(j) {
+ if (*j == 0) {
+ CHECK_TRAP64(r.Call(*i, *j));
+ } else {
+ CHECK_EQ(*i / *j, r.Call(*i, *j));
+ }
+ }
+ }
+}
+
+TEST(Run_WasmI64DivU_Trap) {
+ REQUIRE(I64DivU);
+ WasmRunner<uint64_t> r(MachineType::Uint64(), MachineType::Uint64());
+ BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ CHECK_EQ(0, r.Call(asu64(0), asu64(100)));
+ CHECK_TRAP64(r.Call(asu64(100), asu64(0)));
+ CHECK_TRAP64(r.Call(asu64(1001), asu64(0)));
+ CHECK_TRAP64(r.Call(std::numeric_limits<uint64_t>::max(), asu64(0)));
+}
+
+TEST(Run_WasmI64DivU_Byzero_Const) {
+ REQUIRE(I64DivU);
+ for (uint64_t denom = 0xfffffffffffffffe; denom < 8; denom++) {
+ WasmRunner<uint64_t> r(MachineType::Uint64());
+ BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_I64V_1(denom)));
+
+ for (uint64_t val = 0xfffffffffffffff0; val < 8; val++) {
+ if (denom == 0) {
+ CHECK_TRAP64(r.Call(val));
+ } else {
+ CHECK_EQ(val / denom, r.Call(val));
+ }
+ }
+ }
+}
// kExprI64RemS:
+TEST(Run_WasmI64RemS) {
+ REQUIRE(I64RemS);
+ WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
+ BUILD(r, WASM_I64_REMS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ FOR_INT64_INPUTS(i) {
+ FOR_INT64_INPUTS(j) {
+ if (*j == 0) {
+ CHECK_TRAP64(r.Call(*i, *j));
+ } else {
+ CHECK_EQ(*i % *j, r.Call(*i, *j));
+ }
+ }
+ }
+}
+
+TEST(Run_WasmI64RemS_Trap) {
+ REQUIRE(I64RemS);
+ WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
+ BUILD(r, WASM_I64_REMS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ CHECK_EQ(33, r.Call(asi64(133), asi64(100)));
+ CHECK_EQ(0, r.Call(std::numeric_limits<int64_t>::min(), asi64(-1)));
+ CHECK_TRAP64(r.Call(asi64(100), asi64(0)));
+ CHECK_TRAP64(r.Call(asi64(-1001), asi64(0)));
+ CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), asi64(0)));
+}
+
// kExprI64RemU:
+TEST(Run_WasmI64RemU) {
+ REQUIRE(I64RemU);
+ WasmRunner<uint64_t> r(MachineType::Uint64(), MachineType::Uint64());
+ BUILD(r, WASM_I64_REMU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ FOR_UINT64_INPUTS(i) {
+ FOR_UINT64_INPUTS(j) {
+ if (*j == 0) {
+ CHECK_TRAP64(r.Call(*i, *j));
+ } else {
+ CHECK_EQ(*i % *j, r.Call(*i, *j));
+ }
+ }
+ }
+}
+
+TEST(Run_Wasm_I64RemU_Trap) {
+ REQUIRE(I64RemU);
+ WasmRunner<uint64_t> r(MachineType::Uint64(), MachineType::Uint64());
+ BUILD(r, WASM_I64_REMU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
+ CHECK_EQ(17, r.Call(asu64(217), asu64(100)));
+ CHECK_TRAP64(r.Call(asu64(100), asu64(0)));
+ CHECK_TRAP64(r.Call(asu64(1001), asu64(0)));
+ CHECK_TRAP64(r.Call(std::numeric_limits<uint64_t>::max(), asu64(0)));
+}
+
// kExprI64And:
TEST(Run_Wasm_I64And) {
REQUIRE(I64And);
@@ -1023,83 +1168,6 @@ TEST(Run_Wasm_I64UConvertF64b) {
}
}
-#define as64(x) static_cast<int64_t>(x)
-TEST(Run_WASM_I64DivS_trap) {
- REQUIRE(I64DivS);
- WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
- BUILD(r, WASM_I64_DIVS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
- CHECK_EQ(0, r.Call(as64(0), as64(100)));
- CHECK_TRAP64(r.Call(as64(100), as64(0)));
- CHECK_TRAP64(r.Call(as64(-1001), as64(0)));
- CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), as64(-1)));
- CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), as64(0)));
-}
-
-TEST(Run_WASM_I64RemS_trap) {
- REQUIRE(I64RemS);
- WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
- BUILD(r, WASM_I64_REMS(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
- CHECK_EQ(33, r.Call(as64(133), as64(100)));
- CHECK_EQ(0, r.Call(std::numeric_limits<int64_t>::min(), as64(-1)));
- CHECK_TRAP64(r.Call(as64(100), as64(0)));
- CHECK_TRAP64(r.Call(as64(-1001), as64(0)));
- CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), as64(0)));
-}
-
-TEST(Run_WASM_I64DivU_trap) {
- REQUIRE(I64DivU);
- WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
- BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
- CHECK_EQ(0, r.Call(as64(0), as64(100)));
- CHECK_EQ(0, r.Call(std::numeric_limits<int64_t>::min(), as64(-1)));
- CHECK_TRAP64(r.Call(as64(100), as64(0)));
- CHECK_TRAP64(r.Call(as64(-1001), as64(0)));
- CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), as64(0)));
-}
-
-TEST(Run_WASM_I64RemU_trap) {
- REQUIRE(I64RemU);
- WasmRunner<int64_t> r(MachineType::Int64(), MachineType::Int64());
- BUILD(r, WASM_I64_REMU(WASM_GET_LOCAL(0), WASM_GET_LOCAL(1)));
- CHECK_EQ(17, r.Call(as64(217), as64(100)));
- CHECK_TRAP64(r.Call(as64(100), as64(0)));
- CHECK_TRAP64(r.Call(as64(-1001), as64(0)));
- CHECK_TRAP64(r.Call(std::numeric_limits<int64_t>::min(), as64(0)));
- CHECK_EQ(std::numeric_limits<int64_t>::min(),
- r.Call(std::numeric_limits<int64_t>::min(), as64(-1)));
-}
-
-TEST(Run_WASM_I64DivS_byzero_const) {
- REQUIRE(I64DivS);
- for (int8_t denom = -2; denom < 8; denom++) {
- WasmRunner<int64_t> r(MachineType::Int64());
- BUILD(r, WASM_I64_DIVS(WASM_GET_LOCAL(0), WASM_I64V_1(denom)));
- for (int64_t val = -7; val < 8; val++) {
- if (denom == 0) {
- CHECK_TRAP64(r.Call(val));
- } else {
- CHECK_EQ(val / denom, r.Call(val));
- }
- }
- }
-}
-
-TEST(Run_WASM_I64DivU_byzero_const) {
- REQUIRE(I64DivU);
- for (uint64_t denom = 0xfffffffffffffffe; denom < 8; denom++) {
- WasmRunner<uint64_t> r(MachineType::Uint64());
- BUILD(r, WASM_I64_DIVU(WASM_GET_LOCAL(0), WASM_I64V_1(denom)));
-
- for (uint64_t val = 0xfffffffffffffff0; val < 8; val++) {
- if (denom == 0) {
- CHECK_TRAP64(r.Call(val));
- } else {
- CHECK_EQ(val / denom, r.Call(val));
- }
- }
- }
-}
-
TEST(Run_Wasm_F64ReinterpretI64) {
REQUIRE(F64ReinterpretI64);
TestingModule module;
« no previous file with comments | « test/cctest/wasm/test-run-wasm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698