Show more different NaCl loading errors.

chrome/common/nacl_types.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/nacl_types.h"
 
 namespace nacl {
 
 NaClStartParams::NaClStartParams()
     : validation_cache_enabled(false),
@@ skipping 34 matching lines @@
   render_view_id = l.render_view_id;
   permission_bits = l.permission_bits;
   uses_irt = l.uses_irt;
   enable_dyncode_syscalls = l.enable_dyncode_syscalls;
   enable_exception_handling = l.enable_exception_handling;
 }
 
 NaClLaunchParams::~NaClLaunchParams() {
 }
 
+NaClLaunchResult::NaClLaunchResult()
+#if defined(OS_WIN)
+    : imc_channel_handle(-1),

[Mark Seaborn, 2013/07/16 02:02:53]

0 would be safer than -1.  -1 is INVALID_HANDLE_VALUE but it's also the same as
GetCurrentProcess().  See
http://blogs.msdn.com/b/oldnewthing/archive/2004/03/02/82639.aspx

[halyavin, 2013/07/16 08:04:35]

I know, but IPC::GetFileHandleForProcess in ipc/ipc_platform_file.cc uses -1 for
invalid handles and the normal NaCl loading would not work, if ipc will start
duplicate windows handles in IPC messages. So it looks like the intended way to
pass invalid handles over IPC for me.

May be a better alternative is to use
  #include "ipc/ipc_platform_file.h"
  ...
  : imc_channel_handle(IPC::InvalidPlatformFileForTransit()),
We will not even need ifdefs then.

[Mark Seaborn, 2013/07/17 05:29:58]

Yes, that's much better than using a numeric constant.

[halyavin, 2013/07/17 13:12:16]

Done.

+#else
+    : imc_channel_handle(),
+#endif
+      ipc_channel_handle(),
+      plugin_pid(base::kNullProcessId),
+      plugin_child_id(0) {
+}
+
+NaClLaunchResult::NaClLaunchResult(
+    FileDescriptor imc_channel_handle,
+    const IPC::ChannelHandle& ipc_channel_handle,
+    base::ProcessId plugin_pid,
+    int plugin_child_id)
+    : imc_channel_handle(imc_channel_handle),
+      ipc_channel_handle(ipc_channel_handle),
+      plugin_pid(plugin_pid),
+      plugin_child_id(plugin_child_id) {
+}
+
+NaClLaunchResult::~NaClLaunchResult() {
+}
+
 }  // namespace nacl