Source/core/svg/SVGGlyphElement.cpp - Issue 18045006: Use toSVGFontElement() instead of static_cast<SVGFontElement*>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGlyphElement.cpp

Issue 18045006: Use toSVGFontElement() instead of static_cast<SVGFontElement*> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed svg layout test Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGGlyphElement.cpp

diff --git a/Source/core/svg/SVGGlyphElement.cpp b/Source/core/svg/SVGGlyphElement.cpp

index a900a82e3a5906f74dc6ee06f3c0f81d31a5c00f..e7c04243e4443517b38fdc59b3072bbc967600f2 100644

--- a/Source/core/svg/SVGGlyphElement.cpp

+++ b/Source/core/svg/SVGGlyphElement.cpp

@@ -47,7 +47,7 @@ void SVGGlyphElement::invalidateGlyphCache()

{

ContainerNode* fontNode = parentNode();

if (fontNode && fontNode->hasTagName(SVGNames::fontTag)) {

- if (SVGFontElement* element = static_cast<SVGFontElement*>(fontNode))

+ if (SVGFontElement* element = toSVGFontElement(fontNode))

tkent 2013/07/06 06:14:37 Because fontNode is non-null, element never be nul

element->invalidateGlyphCache();

}

« no previous file with comments | « Source/core/svg/SVGFontFaceElement.cpp ('k') | Source/core/svg/SVGHKernElement.cpp » ('j') | Source/core/svg/SVGHKernElement.cpp » ('J')