Use toSVGFontElement() instead of static_cast<SVGFontElement*>

Use toSVGFontElement() instead of static_cast<SVGFontElement*>

As a step to change static_cast with toXXX, static_cast<SVGFontElement*> can
be changed with toSVGFontElement().

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153761

[gyuyoung-inactive, 2013-07-05 06:50:34]

Add tkent as reviewer.

[tkent, 2013-07-05 12:29:41]

This patch won't work.
Please run SVG layout tests locally, or use try bots.

[gyuyoung-inactive, 2013-07-05 17:40:24]

I can't run layout test now. It looks someone moved it to new place. I will test
it at new place when I became a normal because now is the Friday night ;)

[gyuyoung-inactive, 2013-07-06 04:18:43]

There was wrong casting in SVGFontElement.h. It is fixed now.

[tkent, 2013-07-06 06:14:37]

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGGlyphE...
File Source/core/svg/SVGGlyphElement.cpp (right):

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGGlyphE...
Source/core/svg/SVGGlyphElement.cpp:50: if (SVGFontElement* element =
toSVGFontElement(fontNode))
Because fontNode is non-null, element never be null. 'if' is unnecessary.

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGHKernE...
File Source/core/svg/SVGHKernElement.cpp (right):

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGHKernE...
Source/core/svg/SVGHKernElement.cpp:48: if (SVGFontElement* element =
toSVGFontElement(fontNode))
Ditto.

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGHKernE...
Source/core/svg/SVGHKernElement.cpp:59: if (SVGFontElement* element =
toSVGFontElement(fontNode))
Ditto.

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGVKernE...
File Source/core/svg/SVGVKernElement.cpp (right):

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGVKernE...
Source/core/svg/SVGVKernElement.cpp:47: if (SVGFontElement* element =
toSVGFontElement(fontNode))
Ditto.

https://codereview.chromium.org/18045006/diff/12001/Source/core/svg/SVGVKernE...
Source/core/svg/SVGVKernElement.cpp:59: if (SVGFontElement* element =
toSVGFontElement(fontNode))
Ditto.

[gyuyoung-inactive, 2013-07-07 14:53:18]

On 2013/07/06 06:14:37, tkent wrote:

Fixed all. Thanks.

[gyuyoung-inactive, 2013-07-08 07:16:30]

tkent, could you take a look this again ?

[pdr., 2013-07-08 15:21:46]

On 2013/07/08 07:16:30, gyuyoung wrote:
> tkent, could you take a look this again ?

Looks like tkent's points were addressed.

This looks good now. LGTM

[tkent, 2013-07-08 21:31:11]

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGGlyphE...
File Source/core/svg/SVGGlyphElement.cpp (right):

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGGlyphE...
Source/core/svg/SVGGlyphElement.cpp:50: SVGFontElement* element =
toSVGFontElement(fontNode);
The local variable 'element' is unnecessary.
  toSVGFontElement(fontNode)->invalidateGlyphCache();

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGHKernE...
File Source/core/svg/SVGHKernElement.cpp (right):

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGHKernE...
Source/core/svg/SVGHKernElement.cpp:48: SVGFontElement* element =
toSVGFontElement(fontNode);
Ditto.

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGHKernE...
Source/core/svg/SVGHKernElement.cpp:59: SVGFontElement* element =
toSVGFontElement(fontNode);
Ditto.

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGVKernE...
File Source/core/svg/SVGVKernElement.cpp (right):

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGVKernE...
Source/core/svg/SVGVKernElement.cpp:47: SVGFontElement* element =
toSVGFontElement(fontNode);
Ditto.

https://codereview.chromium.org/18045006/diff/18001/Source/core/svg/SVGVKernE...
Source/core/svg/SVGVKernElement.cpp:59: SVGFontElement* element =
toSVGFontElement(fontNode);
Ditto.

[gyuyoung-inactive, 2013-07-09 02:50:13]

Fixed all again. Thank you for you guys review.

[tkent, 2013-07-09 03:02:35]

lgtm

[commit-bot: I haz the power, 2013-07-09 03:02:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18045006/29001

[commit-bot: I haz the power, 2013-07-09 03:34:13]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-07-09 05:30:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18045006/29001

[commit-bot: I haz the power, 2013-07-09 07:54:57]

Change committed as 153761