Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 1804433005: Replace old CHECKs by DCHECKs in HandleApiCall (Closed)

Created:
4 years, 9 months ago by ofrobots
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace old CHECKs by DCHECKs in HandleApiCall HandleApiCall is one of the most heavily used builtins on Node.js. Replace some old CHECKs with DCHECKs. R=ishell@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/36f6f5e1aae04dc394294a1067a1fef691dcd505 Cr-Commit-Position: refs/heads/master@{#34758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/builtins.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ofrobots
4 years, 9 months ago (2016-03-14 17:31:58 UTC) #1
Igor Sheludko
lgtm
4 years, 9 months ago (2016-03-14 17:32:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804433005/1
4 years, 9 months ago (2016-03-14 17:39:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 17:59:35 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 18:01:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36f6f5e1aae04dc394294a1067a1fef691dcd505
Cr-Commit-Position: refs/heads/master@{#34758}

Powered by Google App Engine
This is Rietveld 408576698