Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: test/cctest/test-serialize.cc

Issue 1804433004: [serializer] add options to compile eagerly and pre-age for code cache. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/snapshot/deserializer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index e76588b1602acc3a03a066945cff946d78049b25..0fc06d63639665dc87917b9fa04dc0d2ea64bde0 100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -1642,6 +1642,61 @@ TEST(CodeSerializerInternalReference) {
isolate->Dispose();
}
+TEST(CodeSerializerEagerCompilationAndPreAge) {
+ if (FLAG_ignition) return;
+
+ FLAG_lazy = true;
+ FLAG_serialize_toplevel = true;
+ FLAG_serialize_age_code = true;
+ FLAG_serialize_eager = true;
+ FLAG_min_preparse_length = 1;
+
+ static const char* source =
+ "function f() {"
+ " function g() {"
+ " return 1;"
+ " }"
+ " return g();"
+ "}"
+ "'abcdef';";
+
+ v8::ScriptCompiler::CachedData* cache = ProduceCache(source);
+
+ v8::Isolate::CreateParams create_params;
+ create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
+ v8::Isolate* isolate2 = v8::Isolate::New(create_params);
+ {
+ v8::Isolate::Scope iscope(isolate2);
+ v8::HandleScope scope(isolate2);
+ v8::Local<v8::Context> context = v8::Context::New(isolate2);
+ v8::Context::Scope context_scope(context);
+
+ v8::Local<v8::String> source_str = v8_str(source);
+ v8::ScriptOrigin origin(v8_str("test"));
+ v8::ScriptCompiler::Source source(source_str, origin, cache);
+ v8::Local<v8::UnboundScript> unbound =
+ v8::ScriptCompiler::CompileUnboundScript(
+ isolate2, &source, v8::ScriptCompiler::kConsumeCodeCache)
+ .ToLocalChecked();
+
+ CHECK(!cache->rejected);
+
+ Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate2);
+ HandleScope i_scope(i_isolate);
+ Handle<SharedFunctionInfo> toplevel = v8::Utils::OpenHandle(*unbound);
+ Handle<Script> script(Script::cast(toplevel->script()));
+ WeakFixedArray::Iterator iterator(script->shared_function_infos());
+ // Every function has been pre-compiled from the code cache.
+ int count = 0;
+ while (SharedFunctionInfo* shared = iterator.Next<SharedFunctionInfo>()) {
+ CHECK(shared->is_compiled());
+ CHECK_EQ(Code::kPreAgedCodeAge, shared->code()->GetAge());
+ count++;
+ }
+ CHECK_EQ(3, count);
+ }
+ isolate2->Dispose();
+}
TEST(Regress503552) {
// Test that the code serializer can deal with weak cells that form a linked
« no previous file with comments | « src/snapshot/deserializer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698