Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1804383002: Remove use counters for Element methods that have been settled in spec (Closed)

Created:
4 years, 9 months ago by philipj_slow
Modified:
4 years, 9 months ago
Reviewers:
tkent, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use counters for Element methods that have been settled in spec https://dom.spec.whatwg.org/#interface-element This also moves the non-spec'd webkitMatchesSelector, insertAdjacentElement and insertAdjacentText. The use counter for webkitMatchesSelector is left in place, because it it's somewhat interesting to follow its decline. The usage ought to be dominated by old versions of jQuery and other libraries, and so it says something about how long it takes for those libraries to be dropped or upgraded in the wild. jQuery and other libraries were updated around the time that the unprefixed matches was shipped in Blink, and usage of webkitMatchesSelector has roughly halved every year since. (Since it's now implemented in all engines, it's still unlikely to ever be removed.) Original commits: https://crrev.com/d92494c5c13990d8ab8d8cd73b0a20b8b2dee1e9 https://crrev.com/a706ad3cd488d6827cfcc99cd67cc30625296928 https://crrev.com/709823c231eb406d6928938c745effb16d6b3b3c https://crrev.com/45b5b0427c403ba30d0067921b2639a31f0190df https://crrev.com/6bcc2fb1c405cca7971ef6f361d94f8e8c63e726 BUG=460722 Committed: https://crrev.com/5e2a7d4d2ade23509e4e00464736556db8eff59d Cr-Commit-Position: refs/heads/master@{#381701}

Patch Set 1 #

Total comments: 2

Patch Set 2 : keep counting webkitMatchesSelector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M third_party/WebKit/Source/core/dom/Element.idl View 1 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804383002/1
4 years, 9 months ago (2016-03-16 10:31:03 UTC) #2
philipj_slow
tkent@, ojan@, you reviewed some of the original CLs. My thinking here is that when ...
4 years, 9 months ago (2016-03-16 11:02:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 13:16:40 UTC) #6
tkent
lgtm https://codereview.chromium.org/1804383002/diff/1/third_party/WebKit/Source/core/dom/Element.idl File third_party/WebKit/Source/core/dom/Element.idl (right): https://codereview.chromium.org/1804383002/diff/1/third_party/WebKit/Source/core/dom/Element.idl#newcode61 third_party/WebKit/Source/core/dom/Element.idl:61: [RaisesException, ImplementedAs=matches] boolean webkitMatchesSelector(DOMString selectors); // historical alias ...
4 years, 9 months ago (2016-03-16 23:57:46 UTC) #7
philipj_slow
https://codereview.chromium.org/1804383002/diff/1/third_party/WebKit/Source/core/dom/Element.idl File third_party/WebKit/Source/core/dom/Element.idl (right): https://codereview.chromium.org/1804383002/diff/1/third_party/WebKit/Source/core/dom/Element.idl#newcode61 third_party/WebKit/Source/core/dom/Element.idl:61: [RaisesException, ImplementedAs=matches] boolean webkitMatchesSelector(DOMString selectors); // historical alias of ...
4 years, 9 months ago (2016-03-17 10:41:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804383002/20001
4 years, 9 months ago (2016-03-17 10:52:26 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 13:28:05 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 13:29:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e2a7d4d2ade23509e4e00464736556db8eff59d
Cr-Commit-Position: refs/heads/master@{#381701}

Powered by Google App Engine
This is Rietveld 408576698