Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804343002: [MD] Fix bookmark bar button overflow during bar animation. (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Fix bookmark bar button overflow during bar animation. BUG=595167 Committed: https://crrev.com/394208b1512d343f32bd9ddd606d9abae88be906 Cr-Commit-Position: refs/heads/master@{#381528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 9 months ago (2016-03-16 01:01:25 UTC) #2
sky
LGTM - I'm getting nervous about the number of additional layers being created. I filed ...
4 years, 9 months ago (2016-03-16 15:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804343002/1
4 years, 9 months ago (2016-03-16 19:31:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:48:24 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:50:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/394208b1512d343f32bd9ddd606d9abae88be906
Cr-Commit-Position: refs/heads/master@{#381528}

Powered by Google App Engine
This is Rietveld 408576698