Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1804303002: Save variables on stack to help determine why GPU watchdog is firing. (Closed)

Created:
4 years, 9 months ago by jbauman
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Save variables on stack to help determine why GPU watchdog is firing. Grab the current time in various formats so we can compare how long it's been since the last ack. Also use QueryUnbiasedInterruptTime to determine whether the computer has been suspended recently. BUG=588342 Committed: https://crrev.com/e6b5e253cf3dfd3da58248704e8cd8725b336f59 Cr-Commit-Position: refs/heads/master@{#381656}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M content/gpu/gpu_watchdog_thread.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 1 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jbauman
4 years, 9 months ago (2016-03-16 19:42:05 UTC) #3
jbauman
4 years, 9 months ago (2016-03-17 01:32:03 UTC) #5
piman
lgtm
4 years, 9 months ago (2016-03-17 01:34:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804303002/20001
4 years, 9 months ago (2016-03-17 01:39:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 03:25:16 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 03:28:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6b5e253cf3dfd3da58248704e8cd8725b336f59
Cr-Commit-Position: refs/heads/master@{#381656}

Powered by Google App Engine
This is Rietveld 408576698