Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1804273003: Get rid of Coercion and Cast. (Closed)

Created:
4 years, 9 months ago by Bob Nystrom
Modified:
4 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of Coercion and Cast. Now that there is only one kind of cast, a downcast, the extra types are no longer needed. This will require a few tweaks in DDC when it upgrades to this version of analyzer, but I think they're minor. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/1c6d6fbb7a6f579392141c74f90aba9ee91f5230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -98 lines) Patch
M pkg/analyzer/lib/src/task/strong/checker.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong/info.dart View 14 chunks +65 lines, -95 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 9 months ago (2016-03-15 22:33:16 UTC) #2
Jennifer Messerly
lgtm
4 years, 9 months ago (2016-03-15 22:39:03 UTC) #3
Bob Nystrom
4 years, 9 months ago (2016-03-15 23:19:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c6d6fbb7a6f579392141c74f90aba9ee91f5230 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698