Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804273002: Removing CRWUISimpleWebViewController (Closed)

Created:
4 years, 9 months ago by shreyasv1
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing CRWUISimpleWebViewController No longer needed. BUG=579697 Committed: https://crrev.com/4caf5d6fb5d3ab9e8d53db06350cc7a45a6f3fa0 Cr-Commit-Position: refs/heads/master@{#381539}

Patch Set 1 #

Patch Set 2 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -244 lines) Patch
M ios/web/BUILD.gn View 1 2 chunks +0 lines, -3 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
D ios/web/web_state/ui/crw_ui_simple_web_view_controller.h View 1 chunk +0 lines, -21 lines 0 comments Download
D ios/web/web_state/ui/crw_ui_simple_web_view_controller.mm View 1 chunk +0 lines, -106 lines 0 comments Download
D ios/web/web_state/ui/crw_ui_simple_web_view_controller_unittest.mm View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
shreyasv1
4 years, 9 months ago (2016-03-15 22:09:40 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 9 months ago (2016-03-15 22:13:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804273002/1
4 years, 9 months ago (2016-03-15 22:16:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/4847)
4 years, 9 months ago (2016-03-15 22:23:06 UTC) #7
Eugene But (OOO till 7-30)
unit test should also be removed from gyp and gn...
4 years, 9 months ago (2016-03-15 22:24:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804273002/20001
4 years, 9 months ago (2016-03-16 20:05:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 20:59:09 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 21:01:21 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4caf5d6fb5d3ab9e8d53db06350cc7a45a6f3fa0
Cr-Commit-Position: refs/heads/master@{#381539}

Powered by Google App Engine
This is Rietveld 408576698