FPDF_PageDelete must delete XFA pages as well.

fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

Index: fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp
diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp
index ede9b7e8924b838412b8f9d0f9f5be3b9289f7a5..ea411ae7580bbcc9aa6d2cb2f91dad955a0ca2b8 100644
--- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp
@@ -182,6 +182,14 @@ CPDFXFA_Page* CPDFXFA_Document::GetPage(IXFA_PageView* pPage) {
   return NULL;
 }
 
+void CPDFXFA_Document::DeletePage(int page_index) {
+  if (page_index < 0 || page_index >= m_XFAPageList.GetSize())
+    return;
+
+  if (CPDFXFA_Page* pPage = m_XFAPageList.GetAt(page_index))
+    pPage->Release();

[dsinclair, 2016/03/15 18:50:59]

Does this need to set m_XFAPageList[page_index] == nullptr? (Or whatever the
right syntax is)

[Tom Sepez, 2016/03/15 19:21:54]

No, because CPDFXFA_Page::Release() will call into
CPDFXFA_Document::RemovePage() which will then do the
m_XFAPageList.SetAt(page->GetPageIndex(), NULL) when the page is removed.

+}
+
 void CPDFXFA_Document::RemovePage(CPDFXFA_Page* page) {
   m_XFAPageList.SetAt(page->GetPageIndex(), NULL);
 }