FPDF_PageDelete must delete XFA pages as well.

FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.

BUG=594111
R=dsinclair@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/744da70149c450d2f387a1fa325a3074ac2edb0c

[Tom Sepez, 2016-03-15 18:46:52]

Description was changed from

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents.

BUG=594111
==========

to

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In print preview,
chromium sometimes first inserts blank pages and
then replaces them later on.

BUG=594111
==========

[Tom Sepez, 2016-03-15 18:46:52]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-03-15 18:47:27]

Description was changed from

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In print preview,
chromium sometimes first inserts blank pages and
then replaces them later on.

BUG=594111
==========

to

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.

BUG=594111
==========

[Tom Sepez, 2016-03-15 18:48:12]

Dan, for review.

[dsinclair, 2016-03-15 18:50:59]

https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:190: pPage->Release();
Does this need to set m_XFAPageList[page_index] == nullptr? (Or whatever the
right syntax is)

[Tom Sepez, 2016-03-15 19:21:54]

https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:190: pPage->Release();
On 2016/03/15 18:50:59, dsinclair wrote:
> Does this need to set m_XFAPageList[page_index] == nullptr? (Or whatever the
> right syntax is)

No, because CPDFXFA_Page::Release() will call into
CPDFXFA_Document::RemovePage() which will then do the
m_XFAPageList.SetAt(page->GetPageIndex(), NULL) when the page is removed.

[Tom Sepez, 2016-03-15 19:24:04]

On 2016/03/15 19:21:54, Tom Sepez wrote:
>
https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
> File fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp (right):
> 
>
https://codereview.chromium.org/1804163002/diff/1/fpdfsdk/fpdfxfa/fpdfxfa_doc...
> fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp:190: pPage->Release();
> On 2016/03/15 18:50:59, dsinclair wrote:
> > Does this need to set m_XFAPageList[page_index] == nullptr? (Or whatever the
> > right syntax is)
> 
> No, because CPDFXFA_Page::Release() will call into
> CPDFXFA_Document::RemovePage() which will then do the
> m_XFAPageList.SetAt(page->GetPageIndex(), NULL) when the page is removed.

(This happens every time, since there is no way to increment the page's ref
count, as it turns out.  But that's for another day).

[dsinclair, 2016-03-15 19:30:40]

lgtm

[Tom Sepez, 2016-03-15 19:43:12]

Description was changed from

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.

BUG=594111
==========

to

==========
FPDF_PageDelete must delete XFA pages as well.

Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.

BUG=594111
R=dsinclair@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/744da70149c450d2f387a1fa325a3074ac2e...
==========

[Tom Sepez, 2016-03-15 19:43:14]

Committed patchset #2 (id:20001) manually as
744da70149c450d2f387a1fa325a3074ac2edb0c (presubmit successful).