Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1804143002: Enable IOSurface2DCanvas pixel tests. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable IOSurface2DCanvas pixel tests. The reference images have been made by the bots. BUG=579664 Committed: https://crrev.com/e354616ed36aeee30d88e736761e5a6a809b43ed Cr-Commit-Position: refs/heads/master@{#382769}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
erikchen
kbr: Please review.
4 years, 9 months ago (2016-03-15 17:45:16 UTC) #2
Ken Russell (switch to Gerrit)
LGTM Verified that from one recent build, gs://chromium-gpu-archive/reference-images/Pixel_IOSurface2DCanvas_v1_mac_10de_0fe9_msaa.png looks correct.
4 years, 9 months ago (2016-03-15 21:03:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804143002/1
4 years, 9 months ago (2016-03-23 00:31:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/8002) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 9 months ago (2016-03-23 00:34:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804143002/20001
4 years, 9 months ago (2016-03-23 00:49:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 02:10:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 02:11:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e354616ed36aeee30d88e736761e5a6a809b43ed
Cr-Commit-Position: refs/heads/master@{#382769}

Powered by Google App Engine
This is Rietveld 408576698