Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/extensions/extension_action_runner_browsertest.cc

Issue 1804123003: [Extensions] Refactor extension action execution (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_runner_browsertest.cc
diff --git a/chrome/browser/extensions/extension_action_runner_browsertest.cc b/chrome/browser/extensions/extension_action_runner_browsertest.cc
index c71cdf177b7228c771d4efe625d3baa3c1868446..f55091dc97e506f1c61f4bfc0bbe6df3549e2bed 100644
--- a/chrome/browser/extensions/extension_action_runner_browsertest.cc
+++ b/chrome/browser/extensions/extension_action_runner_browsertest.cc
@@ -261,7 +261,7 @@ testing::AssertionResult ActiveScriptTester::Verify() {
DCHECK(wants_to_run);
// Grant permission by clicking on the extension action.
- runner->OnClicked(extension_);
+ runner->RunAction(extension_, true);
// Now, the extension should be able to inject the script.
inject_success_listener_->WaitUntilSatisfied();
@@ -371,7 +371,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionActionRunnerBrowserTest,
new ExtensionTestMessageListener(kInjectSucceeded,
false /* won't reply */));
inject_success_listener.set_extension_id(extension1->id());
- action_runner->OnClicked(extension1);
+ action_runner->RunAction(extension1, true);
inject_success_listener.WaitUntilSatisfied();
}

Powered by Google App Engine
This is Rietveld 408576698