Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1804113002: Add dEQP-EGL tests to GPU optional and ANGLE try bots. (Closed)

Created:
4 years, 9 months ago by Jamie Madill
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dEQP-EGL tests to GPU optional and ANGLE try bots. These tests give regression coverage for ANGLE's EGL layer. Windows-only for now, until we have the correct suppressions in place for other platforms. BUG=595018 Committed: https://crrev.com/9b384b78a990a8d440fc2dc05a1fa59acd3d6722 Cr-Commit-Position: refs/heads/master@{#381363}

Patch Set 1 #

Patch Set 2 : Remove Linux for now #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -9 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 1 1 chunk +21 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.gpu.fyi.json View 1 6 chunks +39 lines, -9 lines 1 comment Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804113002/1
4 years, 9 months ago (2016-03-15 17:21:53 UTC) #3
Jamie Madill
PTAL Ken, this gives some coverage for ANGLE's EGL layer. It will become more important ...
4 years, 9 months ago (2016-03-15 21:25:36 UTC) #7
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/1804113002/diff/20001/testing/buildbot/chromium.gpu.fyi.json File testing/buildbot/chromium.gpu.fyi.json (left): https://codereview.chromium.org/1804113002/diff/20001/testing/buildbot/chromium.gpu.fyi.json#oldcode480 testing/buildbot/chromium.gpu.fyi.json:480: "can_use_on_swarming_builders": true I'm a little surprised to see ...
4 years, 9 months ago (2016-03-15 21:30:32 UTC) #8
Jamie Madill
That is a little bit odd. I'm not sure why they are showing up here.
4 years, 9 months ago (2016-03-15 21:36:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804113002/20001
4 years, 9 months ago (2016-03-15 21:36:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/195692)
4 years, 9 months ago (2016-03-15 23:02:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804113002/20001
4 years, 9 months ago (2016-03-15 23:26:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 00:21:48 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 00:24:03 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b384b78a990a8d440fc2dc05a1fa59acd3d6722
Cr-Commit-Position: refs/heads/master@{#381363}

Powered by Google App Engine
This is Rietveld 408576698