Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1804063002: Fix wheel scrolling over scrollbar not scrolling page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp
index 645d51be8477559971abd6939f700eb84dfff90a..4b399f13e7b682a937ae32bfecce58c3e14d6b54 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp
@@ -1798,6 +1798,10 @@ WebInputEventResult EventHandler::handleWheelEvent(const PlatformWheelEvent& eve
if (node && node->isTextNode())
node = FlatTreeTraversal::parent(*node);
+ // If we're over a scrollbar, scroll the document.
jbroman 2016/03/16 15:41:00 Just the (root?) frame scrollbars, right? Presumab
bokan 2016/03/16 18:01:45 Yah, if it's over an overflow div innerNode will h
+ if (!node && result.scrollbar())
+ node = doc->documentElement();
+
bool sendDOMEvent = true;
LocalFrame* subframe = subframeForTargetNode(node);
if (subframe) {

Powered by Google App Engine
This is Rietveld 408576698