third_party/WebKit/LayoutTests/fast/events/wheel-in-scrollbar.html - Issue 1804063002: Fix wheel scrolling over scrollbar not scrolling page.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/wheel-in-scrollbar.html

Issue 1804063002: Fix wheel scrolling over scrollbar not scrolling page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 description("Test that wheel scrolling over the page scrollbar scrolls " +

	5 "the page. We also placed an overflow div below the " +

	6 "scrollbar to make sure we target the page and not the div " +

	7 "in that case.");

	8

	9 var overflowDiv;

	10

	11 window.onload = function() {

	12 if (!window.testRunner \|\| !window.eventSender)

	13 return;

	14

	15 internals.settings.setScrollAnimatorEnabled(false);

	16

	17 overflowDiv = document.getElementById('overflowDiv');

	18

	19 // Move the mouse over the vertical scrollbar.

	20 eventSender.mouseMoveTo(790, 300);

	21

	22 // Scroll down precisely by 30 px.

	23 eventSender.continuousMouseScrollBy(0, -30, false, true);

	24

	25 shouldBe('window.scrollY', '30');
	dtapuska 2016/03/15 18:57:18 This test assumes that scrolling occurs on mouse s This test assumes that scrolling occurs on mouse scrolls. Which isn't true for wheel gestures. A setTimeout(function() {....}, 0); makes it pass for wheel gestures (although it is currently broken but I've fixed it locally)
	26 shouldBe('overflowDiv.scrollTop', '0');

	27 finishJSTest();
	jbroman 2016/03/16 15:41:00 "finishJSTest()" without "jsTestIsAsync = true;" i "finishJSTest()" without "jsTestIsAsync = true;" is surprising; is this intended? bokan 2016/03/16 18:01:45 Nope, it was cargo-culted. I've removed it since i Show quoted text On 2016/03/16 15:41:00, jbroman wrote: > "finishJSTest()" without "jsTestIsAsync = true;" is surprising; is this > intended? Nope, it was cargo-culted. I've removed it since it's not needed. jbroman 2016/03/16 18:05:52 Actually, I think you do want jsTestIsAsync and fi Show quoted text On 2016/03/16 at 18:01:45, bokan wrote: > On 2016/03/16 15:41:00, jbroman wrote: > > "finishJSTest()" without "jsTestIsAsync = true;" is surprising; is this > > intended? > > Nope, it was cargo-culted. I've removed it since it's not needed. Actually, I think you do want jsTestIsAsync and finishJSTest. You'll note that in the previous patchset, you had two "TEST COMPLETE" lines, and in this one you only have one, but it's in the middle. It probably isn't flaky in this case, but the test-complete code should probably only run when the test is actually complete. bokan 2016/03/16 19:18:15 Yah, I think you're right. I thought the layout te Show quoted text On 2016/03/16 18:05:52, jbroman wrote: > On 2016/03/16 at 18:01:45, bokan wrote: > > On 2016/03/16 15:41:00, jbroman wrote: > > > "finishJSTest()" without "jsTestIsAsync = true;" is surprising; is this > > > intended? > > > > Nope, it was cargo-culted. I've removed it since it's not needed. > > Actually, I think you do want jsTestIsAsync and finishJSTest. You'll note that > in the previous patchset, you had two "TEST COMPLETE" lines, and in this one you > only have one, but it's in the middle. > > It probably isn't flaky in this case, but the test-complete code should probably > only run when the test is actually complete. Yah, I think you're right. I thought the layout test is "finished" after the load event but I guess that gets run before my handler.
	28 }

	29 </script>

	30

	31 <body style="margin:0">

	32 <div id="overflowDiv" style="width:1000px; height:500px; overflow:scroll">

	33 <div style="height: 1000px"></div>

	34 </div>

	35 <div style="height: 1000px"></div>

	36 </body>

OLD	NEW