Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove 'anonymous'. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index e103e71e6341ad8a24f51106629b65d23784643f..4b350c318dc0e56939615760a7890f953790edee 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -2429,7 +2429,13 @@ class WebViewCaptureTest : public WebViewTest {
INSTANTIATE_TEST_CASE_P(WebViewTests, WebViewCaptureTest, testing::Bool());
IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestZoomAPI) {
- TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);
+ // TODO(wjmaclean): This test is broken, but only when the
+ // --use-cross-process-frames-for-guests flag is specified. This needs to be
+ // fixed. See also comment in
+ // CrossProcessFrameConnector::OnFrameRectChanged().
+ // http://crbug.com/607978
+ if (!GetParam())
+ TestHelper("testZoomAPI", "web_view/shim", NO_TEST_SERVER);
}
IN_PROC_BROWSER_TEST_P(WebViewTest, Shim_TestFindAPI) {
« no previous file with comments | « no previous file | chrome/browser/renderer_preferences_util.cc » ('j') | third_party/WebKit/Source/web/WebViewImpl.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698