content/renderer/render_frame_impl.cc - Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, exclude part of test since not supported on Android. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 29958841fffe598a1847d66da414a6a16353a047..86847c6747ef6edd9f7f6b2c2b08ff2627075c5f 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4568,6 +4568,8 @@ void RenderFrameImpl::SendDidCommitProvisionalLoad(

DCHECK(!navigation_state->request_params().should_clear_history_list);

params.history_list_was_cleared = false;

params.report_type = FrameMsg_UILoadMetricsReportType::NO_REPORT;

+ // Subframes should match the zoom level of the main frame.

+ render_view_->webview()->setZoomLevel(render_view_->page_zoom_level());

}

// This message needs to be sent before any of allowScripts(),

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/public/test/browser_test_utils.cc ('k') | content/renderer/render_thread_impl.h » ('j') | no next file with comments »