content/browser/frame_host/cross_process_frame_connector.cc - Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revise tests to use constancy of innerWidth for fixed-size iframes. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_preferences_util.cc ('k') | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/iframe_zoom_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index b5e415ced16124ab9c7b22272546a422fa03fedb..a066bc996de73254416dbe064500bf9ab639fbd6 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -199,6 +199,11 @@ void CrossProcessFrameConnector::OnForwardInputEvent(

void CrossProcessFrameConnector::OnFrameRectChanged(

const gfx::Rect& frame_rect) {

+ // TODO(wjmaclean) When changing the zoom of a WebView child without also

+ // changing the zoom of the embedder (e.g. using WebView.setZoom()), we

+ // shouldn't propagate this change in the frame rect. We need to find a way

+ // to detect when this happens.

+ // http://crbug.com/xxxxxx <- Don't land without filing this bug.

if (!frame_rect.size().IsEmpty())

SetRect(frame_rect);

}