content/common/frame_messages.h - Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't use WeakPtr for PostTask on UI thread. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/view_messages.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index d8e5931037314370feaff3f5ee0e54216d962fb8..165b61a29e6fb430ca98baabb3a8a09cba21936b 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -790,6 +790,15 @@ IPC_MESSAGE_ROUTED1(FrameMsg_SetTextTrackSettings,

// Posts a message from a frame in another process to the current renderer.

IPC_MESSAGE_ROUTED1(FrameMsg_PostMessageEvent, FrameMsg_PostMessage_Params)

+// Instructs the frame to set its zoom level to match the owning WebContents.

alexmos 2016/04/05 18:00:54 The comments for these two messages are the same -

wjmaclean 2016/04/05 20:22:00 Done.

alexmos 2016/04/07 01:20:56 They're still the same in the latest PS :)

wjmaclean 2016/04/07 12:55:36 Ooops. No matter, as these messages go away in the

+IPC_MESSAGE_ROUTED2(FrameMsg_SetTemporaryZoomLevel,

+ double /* zoom_level*/,

+ bool /* is_temporary */)

+// Instructs the frame to set its zoom level to match the owning WebContents.

+IPC_MESSAGE_ROUTED1(FrameMsg_SetZoomLevelFromWebContents,

+ double /* zoom_level*/)

#if defined(OS_ANDROID)

// Sent when the browser wants the bounding boxes of the current find matches.