Fix page zoom to be frame-centric for out-of-process frames.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 257 matching lines @@
 
 SiteInstanceImpl* RenderViewHostImpl::GetSiteInstance() const {
   return instance_.get();
 }
 
 bool RenderViewHostImpl::CreateRenderView(
     int opener_frame_route_id,
     int proxy_route_id,
     int32_t max_page_id,
     const FrameReplicationState& replicated_frame_state,
-    bool window_was_created_with_opener) {
+    bool window_was_created_with_opener,
+    double zoom_level) {
   TRACE_EVENT0("renderer_host,navigation",
                "RenderViewHostImpl::CreateRenderView");
   DCHECK(!IsRenderViewLive()) << "Creating view twice";
 
   // The process may (if we're sharing a process with another host that already
   // initialized it) or may not (we have our own process or the old process
   // crashed) have been initialized. Calling Init multiple times will be
   // ignored, so this is safe.
   if (!GetProcess()->Init())
     return false;
@@ skipping 41 matching lines @@
   params.swapped_out = !is_active_;
   params.replicated_frame_state = replicated_frame_state;
   params.proxy_routing_id = proxy_route_id;
   params.hidden = GetWidget()->is_hidden();
   params.never_visible = delegate_->IsNeverVisible();
   params.window_was_created_with_opener = window_was_created_with_opener;
   params.next_page_id = next_page_id;
   params.enable_auto_resize = GetWidget()->auto_resize_enabled();
   params.min_size = GetWidget()->min_size_for_auto_resize();
   params.max_size = GetWidget()->max_size_for_auto_resize();
+  params.preferred_subframe_zoom_level = zoom_level;

[alexmos, 2016/04/07 23:48:08]

It seems that some similar looking params (e.g., never_visible) are fetched from
WC via the delegate_, what do you think about that approach vs. adding another
param to CreateRenderView?  That would avoid touching the plumbing in tests and
passing 0.0 in places where it doesn't matter.

[wjmaclean, 2016/04/08 20:13:29]

It seemed to me that since RenderViewHostDelegate is "An interface implemented
by an object interested in knowing about the state of the RenderViewHost" and
since a zoom level is really a property of a WebContents, or a Page, that it
didn't seem to belong there.

But, I'm willing to be convinced otherwise.

[ncarter (slow), 2016/04/11 22:17:03]

I'm okay with either approach.

Practically, if you do it via the delegate it's harder to get things to work in
intersitials. But it looks like zoom doesn't work properly today in
interstitials anyway.

   GetWidget()->GetResizeParams(&params.initial_size);
 
   if (!Send(new ViewMsg_New(params)))
     return false;
   GetWidget()->SetInitialRenderSizeParams(params.initial_size);
 
   // If the RWHV has not yet been set, the surface ID namespace will get
   // passed down by the call to SetView().
   if (GetWidget()->GetView()) {
     Send(new ViewMsg_SetSurfaceIdNamespace(
@@ skipping 1001 matching lines @@
   } else {
     render_view_ready_on_process_launch_ = true;
   }
 }
 
 void RenderViewHostImpl::RenderViewReady() {
   delegate_->RenderViewReady(this);
 }
 
 }  // namespace content