Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: third_party/WebKit/public/web/WebView.h

Issue 1804023002: Fix page zoom to be frame-centric for out-of-process frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address alexmos@ comments, run two experiments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 // of 300% and 50% of original size, respectively. Only plugins use 198 // of 300% and 50% of original size, respectively. Only plugins use
199 // non whole-numbers, since they might choose to have specific zoom level so 199 // non whole-numbers, since they might choose to have specific zoom level so
200 // that fixed-width content is fit-to-page-width, for example. 200 // that fixed-width content is fit-to-page-width, for example.
201 virtual double zoomLevel() = 0; 201 virtual double zoomLevel() = 0;
202 202
203 // Changes the zoom level to the specified level, clamping at the limits 203 // Changes the zoom level to the specified level, clamping at the limits
204 // noted above, and returns the current zoom level after applying the 204 // noted above, and returns the current zoom level after applying the
205 // change. 205 // change.
206 virtual double setZoomLevel(double) = 0; 206 virtual double setZoomLevel(double) = 0;
207 207
208 // Sets the zoom level for the specified WebLocalFrame.
alexmos 2016/04/07 01:20:56 nit: add "and its local descendants" or something
wjmaclean 2016/04/07 12:55:36 This disappears in the new patch.
209 virtual double setZoomLevelForFrame(WebLocalFrame*, double zoomLevel) = 0;
210
208 // Updates the zoom limits for this view. 211 // Updates the zoom limits for this view.
209 virtual void zoomLimitsChanged(double minimumZoomLevel, 212 virtual void zoomLimitsChanged(double minimumZoomLevel,
210 double maximumZoomLevel) = 0; 213 double maximumZoomLevel) = 0;
211 214
212 // Helper functions to convert between zoom level and zoom factor. zoom 215 // Helper functions to convert between zoom level and zoom factor. zoom
213 // factor is zoom percent / 100, so 300% = 3.0. 216 // factor is zoom percent / 100, so 300% = 3.0.
214 BLINK_EXPORT static double zoomLevelToZoomFactor(double zoomLevel); 217 BLINK_EXPORT static double zoomLevelToZoomFactor(double zoomLevel);
215 BLINK_EXPORT static double zoomFactorToZoomLevel(double factor); 218 BLINK_EXPORT static double zoomFactorToZoomLevel(double factor);
216 219
217 // Returns the current text zoom factor, where 1.0 is the normal size, > 1.0 220 // Returns the current text zoom factor, where 1.0 is the normal size, > 1.0
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 // context's ability to deal with that failure gracefully can be tested. 483 // context's ability to deal with that failure gracefully can be tested.
481 virtual void forceNextDrawingBufferCreationToFail() = 0; 484 virtual void forceNextDrawingBufferCreationToFail() = 0;
482 485
483 protected: 486 protected:
484 ~WebView() {} 487 ~WebView() {}
485 }; 488 };
486 489
487 } // namespace blink 490 } // namespace blink
488 491
489 #endif 492 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698