impl charsToGlyphs for freetype

src/ports/SkFontHost_FreeType_common.h

Index: src/ports/SkFontHost_FreeType_common.h
diff --git a/src/ports/SkFontHost_FreeType_common.h b/src/ports/SkFontHost_FreeType_common.h
index acf9a4ab2b97c69a769709ec4ce1111bc971c541..6bd3532d66f03d330af27fc0d8e868511485aaa3 100644
--- a/src/ports/SkFontHost_FreeType_common.h
+++ b/src/ports/SkFontHost_FreeType_common.h
@@ -48,7 +48,9 @@ private:
 class SkTypeface_FreeType : public SkTypeface {
 protected:
     SkTypeface_FreeType(Style style, SkFontID uniqueID, bool isFixedPitch)
-        : INHERITED(style, uniqueID, isFixedPitch) {}
+        : INHERITED(style, uniqueID, isFixedPitch)
+        , fGlyphCount(-1)
+    {}
 
     virtual SkScalerContext* onCreateScalerContext(
                                         const SkDescriptor*) const SK_OVERRIDE;
@@ -58,7 +60,13 @@ protected:
                                 const uint32_t*, uint32_t) const SK_OVERRIDE;
     virtual int onGetUPEM() const SK_OVERRIDE;
 
+    virtual int onCharsToGlyphs(const void* chars, Encoding, uint16_t glyphs[],

[bungeman-skia, 2013/07/02 16:04:20]

Adding declarations to common, but putting implementation only in the
non-common. I don't think SkFontHost_FreeType_common.cpp will compile with this
change. Should the impl go in common.cpp?

[reed1, 2013/07/02 16:14:37]

Doh! I didn't notice that disconnect. I will fix it one way or the other.

[reed1, 2013/07/02 16:19:18]

Actually, this is already happening (e.g. onGetUPEM), so I'm not sure what is
right or wrong. I may leave it as is for now, since it does not seem to be worse
than before. Separately I will explore this separation with whomever wanted it
(mozilla?)

+                                int glyphCount) const SK_OVERRIDE;
+    virtual int onCountGlyphs() const SK_OVERRIDE;
+
 private:
+    mutable int fGlyphCount;
+
     typedef SkTypeface INHERITED;
 };