Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2440)

Unified Diff: chrome/browser/permissions/permission_util_unittest.cc

Issue 1803973002: Content Settings: Add RevocationObserver to measure when permissions are revoked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update rappor.xml Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_util_unittest.cc
diff --git a/chrome/browser/permissions/permission_util_unittest.cc b/chrome/browser/permissions/permission_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1c00667f1991ec73335c20cd98a5083adec76656
--- /dev/null
+++ b/chrome/browser/permissions/permission_util_unittest.cc
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/test/histogram_tester.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/permissions/permission_uma_util.h"
+#include "chrome/browser/permissions/permission_util.h"
+#include "chrome/test/base/testing_profile.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class PermissionUtilTest : public testing::Test {
+ content::TestBrowserThreadBundle thread_bundle_;
+};
+
+TEST_F(PermissionUtilTest, SetContentSettingRecordRevocation) {
+ TestingProfile profile;
+ // TODO(tsergeant): Add more comprehensive tests of PermissionUmaUtil.
+ base::HistogramTester histograms;
+ HostContentSettingsMap* map =
+ HostContentSettingsMapFactory::GetForProfile(&profile);
+ GURL host("https://example.com");
+ ContentSettingsType type = CONTENT_SETTINGS_TYPE_GEOLOCATION;
+
+ // Allow->Block triggers a revocation.
+ map->SetContentSettingDefaultScope(host, host, type, std::string(),
+ CONTENT_SETTING_ALLOW);
+ EXPECT_TRUE(PermissionUtil::SetContentSettingAndRecordRevocation(
+ &profile, host, host, type, std::string(), CONTENT_SETTING_BLOCK));
+ histograms.ExpectBucketCount("Permissions.Action.Geolocation",
+ PermissionAction::REVOKED, 1);
+
+ // Block->Allow does not trigger a revocation.
+ EXPECT_FALSE(PermissionUtil::SetContentSettingAndRecordRevocation(
+ &profile, host, host, type, std::string(), CONTENT_SETTING_ALLOW));
+ histograms.ExpectBucketCount("Permissions.Action.Geolocation",
+ PermissionAction::REVOKED, 1);
+
+ // Allow->Default triggers a revocation when default is 'ask'.
+ map->SetDefaultContentSetting(type, CONTENT_SETTING_ASK);
+ EXPECT_TRUE(PermissionUtil::SetContentSettingAndRecordRevocation(
+ &profile, host, host, type, std::string(), CONTENT_SETTING_DEFAULT));
+ histograms.ExpectBucketCount("Permissions.Action.Geolocation",
+ PermissionAction::REVOKED, 2);
+
+ // Allow->Default does not trigger a revocation when default is 'allow'.
+ map->SetDefaultContentSetting(type, CONTENT_SETTING_ALLOW);
+ EXPECT_FALSE(PermissionUtil::SetContentSettingAndRecordRevocation(
+ &profile, host, host, type, std::string(), CONTENT_SETTING_DEFAULT));
+ histograms.ExpectBucketCount("Permissions.Action.Geolocation",
+ PermissionAction::REVOKED, 2);
+}

Powered by Google App Engine
This is Rietveld 408576698