chrome/browser/permissions/permission_uma_util.cc - Issue 1803973002: Content Settings: Add RevocationObserver to measure when permissions are revoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1803973002: Content Settings: Add RevocationObserver to measure when permissions are revoked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update rappor.xml Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_uma_util.h ('k') | chrome/browser/permissions/permission_util.h » ('j') | chrome/browser/permissions/permission_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/permission_uma_util.cc

diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc

index 4a3f649c8d67a512548806aa8736de0876f2a05c..907883587233e4ac930feb5454cfbae4144c2749 100644

--- a/chrome/browser/permissions/permission_uma_util.cc

+++ b/chrome/browser/permissions/permission_uma_util.cc

@@ -35,22 +35,6 @@ using content::PermissionType;

namespace {

-// Enum for UMA purposes, make sure you update histograms.xml if you add new

-// permission actions. Never delete or reorder an entry; only add new entries

-// immediately before PERMISSION_NUM

-enum PermissionAction {

- GRANTED = 0,

- DENIED = 1,

- DISMISSED = 2,

- IGNORED = 3,

- REVOKED = 4,

- REENABLED = 5,

- REQUESTED = 6,

- // Always keep this at the end.

- PERMISSION_ACTION_NUM,

-};

// Deprecated. This method is used for the single-dimensional RAPPOR metrics

// that are being replaced by the multi-dimensional ones.

const std::string GetRapporMetric(PermissionType permission,