chrome/browser/ui/website_settings/website_settings.cc - Issue 1803973002: Content Settings: Add RevocationObserver to measure when permissions are revoked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 1803973002: Content Settings: Add RevocationObserver to measure when permissions are revoked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rewrite patch in permissions layer Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/permissions/permission_util_unittest.cc ('K') | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/website_settings.cc

diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc

index 9996abb1bd02d3c7a724eed37bce73aed2921872..4246c2da3c4bc06a26d19d931ca60ac8860f70ff 100644

--- a/chrome/browser/ui/website_settings/website_settings.cc

+++ b/chrome/browser/ui/website_settings/website_settings.cc

@@ -286,6 +286,8 @@ void WebsiteSettings::OnSitePermissionChanged(ContentSettingsType type,

"WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,

num_values);

// Trigger Rappor sampling if it is a permission revoke action.

+ // TODO(tsergeant): Integrate this with the revocation recording performed

+ // in the permissions layer. See crbug.com/469221.

content::PermissionType permission_type;

if (PermissionUtil::GetPermissionType(type, &permission_type)) {

PermissionUmaUtil::PermissionRevoked(permission_type,