Content Settings: Add RevocationObserver to measure when permissions are revoked

components/content_settings/core/browser/content_settings_observer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_OBSERVER_H_
 #define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_OBSERVER_H_
 
 #include <string>
 
 #include "components/content_settings/core/common/content_settings_pattern.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 
 namespace content_settings {
 
 class Observer {
  public:
   virtual void OnContentSettingChanged(
       const ContentSettingsPattern& primary_pattern,
       const ContentSettingsPattern& secondary_pattern,
       ContentSettingsType content_type,
       std::string resource_identifier) = 0;
 
  protected:
   virtual ~Observer() {}
 };
 
+class RevocationObserver {
+ public:
+  virtual void OnContentSettingRevoked(

[raymes, 2016/03/17 02:05:43]

What are the downsides to adding this to Observer above?

[tsergeant, 2016/03/17 06:25:40]

I was having some problems with it initially, but I've added it to Observer with
a blank implementation and it works fine.

+      const GURL& primary_url,
+      const GURL& secondary_url,
+      ContentSettingsType content_type,
+      std::string resource_identifier) = 0;
+
+ protected:
+  virtual ~RevocationObserver() {}
+};
+
 }  // namespace content_settings
 
 #endif  // COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_OBSERVER_H_