Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 180393002: Remove unused NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr NodeListRootType value (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Remove unused NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr NodeListRootType value Remove unused NodeListIsRootedAtDocumentIfOwnerHasItemrefAttr NodeListRootType value and make the m_rootType bitfield smaller as a result. R=adamk@chromium.org, esprehn@chromium.org, adamk, esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/dom/LiveNodeListBase.h View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
6 years, 10 months ago (2014-02-25 21:18:57 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-25 21:56:19 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-25 21:58:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180393002/1
6 years, 10 months ago (2014-02-25 21:59:03 UTC) #4
esprehn
lgtm
6 years, 10 months ago (2014-02-25 22:04:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180393002/1
6 years, 10 months ago (2014-02-25 23:08:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180393002/1
6 years, 10 months ago (2014-02-25 23:26:59 UTC) #7
Inactive
6 years, 10 months ago (2014-02-26 03:23:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r167846 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698