Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1803903002:
Ship Array.prototype.values (Closed)
|
Created:
4 years, 9 months ago by adamk Modified:
4 years, 9 months ago Reviewers:
Dan Ehrenberg CC:
Michael Hablich, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionShip Array.prototype.values
BUG=v8:4247
LOG=y
Committed: https://crrev.com/0852060f9537e8bfd6ee129d5f57aa8eff161110
Cr-Commit-Position: refs/heads/master@{#34794}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Ship Array.prototype.values BUG=v8:4247 LOG=y ========== to ========== Ship Array.prototype.values BUG=v8:4247 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel ==========
adamk@chromium.org changed reviewers: + littledan@chromium.org
The CQ bit was checked by adamk@chromium.org
The CQ bit was unchecked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803903002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803903002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
Description was changed from ========== Ship Array.prototype.values BUG=v8:4247 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel ========== to ========== Ship Array.prototype.values BUG=v8:4247 LOG=y ==========
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803903002/1
Message was sent while issue was closed.
Description was changed from ========== Ship Array.prototype.values BUG=v8:4247 LOG=y ========== to ========== Ship Array.prototype.values BUG=v8:4247 LOG=y ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Ship Array.prototype.values BUG=v8:4247 LOG=y ========== to ========== Ship Array.prototype.values BUG=v8:4247 LOG=y Committed: https://crrev.com/0852060f9537e8bfd6ee129d5f57aa8eff161110 Cr-Commit-Position: refs/heads/master@{#34794} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0852060f9537e8bfd6ee129d5f57aa8eff161110 Cr-Commit-Position: refs/heads/master@{#34794} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
