Normalize JIDs passed to Spake2Authenticator.

Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
Committed: https://crrev.com/df644193ff164f1d3df85d857f2b21b5ba51f77e
Cr-Commit-Position: refs/heads/master@{#381559}

[Sergey Ulanov, 2016-03-14 23:00:15]

sergeyu@chromium.org changed reviewers:
+ kelvinp@chromium.org

[Sergey Ulanov, 2016-03-14 23:02:47]

Description was changed from

==========
Normalized JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
==========

to

==========
Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
==========

[kelvinp, 2016-03-15 01:02:07]

Should we be more aggressive and normalize all jids once they goes into our
system? In this way, the code in the protocol namespace doesn't need to worry
anymore about JID normalization.

[Sergey Ulanov, 2016-03-16 20:26:54]

On 2016/03/15 01:02:07, kelvinp wrote:
> Should we be more aggressive and normalize all jids once they goes into our
> system? In this way, the code in the protocol namespace doesn't need to worry
> anymore about JID normalization.

There are cases when JID is displayed to the user and in that case don't want
JID to be normalized. E.g. for It2Me the helper ID/email is inferred from the
JID and is shown to the helpee. In that scenario it's better to show
AliceDarcy@gmail.com instead of alicedarcy@gmail.com.

[kelvinp, 2016-03-16 21:07:49]

Sounds good to me.
Lgtm

[kelvinp, 2016-03-16 21:07:50]

Sounds good to me.
Lgtm

[Sergey Ulanov, 2016-03-16 21:10:53]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-03-16 21:11:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1803893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1803893002/1

[commit-bot: I haz the power, 2016-03-16 21:54:20]

Description was changed from

==========
Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
==========

to

==========
Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
==========

[commit-bot: I haz the power, 2016-03-16 21:54:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-16 21:56:03]

Description was changed from

==========
Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698
==========

to

==========
Normalize JIDs passed to Spake2Authenticator.

Spake2Authenticator requires that local_id and remote_id are the same
on both ends of the connection, so JIDs need to be normalized to avoid
issues when one of the ends gets JID in a different case.

BUG=589698

Committed: https://crrev.com/df644193ff164f1d3df85d857f2b21b5ba51f77e
Cr-Commit-Position: refs/heads/master@{#381559}
==========

[commit-bot: I haz the power, 2016-03-16 21:56:04]

Patchset 1 (id:??) landed as
https://crrev.com/df644193ff164f1d3df85d857f2b21b5ba51f77e
Cr-Commit-Position: refs/heads/master@{#381559}