Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1803883002: Reland: Media Galleries Partial Deprecation: Remove image metadata & libexif. (Closed)

Created:
4 years, 9 months ago by tommycli
Modified:
4 years, 9 months ago
Reviewers:
erikchen
CC:
chromium-reviews, extensions-reviews_chromium.org, chromoting-reviews_chromium.org, Lei Zhang, grt+watch_chromium.org, tommycli, oshima+watch_chromium.org, wfh+watch_chromium.org, chromium-apps-reviews_chromium.org, Michael Moss, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Media Galleries Partial Deprecation: Remove image metadata & libexif. This relands https://codereview.chromium.org/1773233002/. Original description: Media Galleries Partial Deprecation: Remove image metadata & libexif. Removing libexif is a great thing. It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues. BUG=542912, 577272 TBR= Committed: https://crrev.com/cd96b6f874573d7089bf2eb9d54ed53d7469bb56 Cr-Commit-Position: refs/heads/master@{#381121}

Patch Set 1 : Original (reverted) patch #

Patch Set 2 : Remove a remnant on MacOSX official build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1893 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M build/experimental/install-build-deps.py View 3 chunks +0 lines, -3 lines 0 comments Download
M build/install-build-deps.sh View 3 chunks +18 lines, -20 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 chunk +0 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.isolate View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_utility.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/media_galleries.idl View 1 chunk +3 lines, -16 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/test.js View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/unit_tests.isolate View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor.h View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor.cc View 1 chunk +0 lines, -465 lines 0 comments Download
D chrome/utility/media_galleries/image_metadata_extractor_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 4 chunks +0 lines, -53 lines 0 comments Download
M testing/chromoting/chromoting_browser_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D testing/libfuzzer/fuzzers/libexif_parser_fuzzer.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/libexif/BUILD.gn View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/libexif/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/libexif/README.chromium View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/libexif/README.security View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/libexif/chromium.patch View 1 chunk +0 lines, -571 lines 0 comments Download
D third_party/libexif/libexif.def View 1 chunk +0 lines, -145 lines 0 comments Download
D third_party/libexif/libexif.gyp View 1 chunk +0 lines, -133 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tommycli
erikchen: PTAL. Patchset 1 -> 2 delta shows the extra lines I had to remove ...
4 years, 9 months ago (2016-03-14 22:35:45 UTC) #3
erikchen
diff between patch set 2/1 lgtm
4 years, 9 months ago (2016-03-14 23:28:31 UTC) #4
tommycli
erikchen: thank you! I'm sending this in with TBR= since everything else has already been ...
4 years, 9 months ago (2016-03-14 23:34:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803883002/20001
4 years, 9 months ago (2016-03-14 23:35:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-14 23:57:05 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 23:58:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd96b6f874573d7089bf2eb9d54ed53d7469bb56
Cr-Commit-Position: refs/heads/master@{#381121}

Powered by Google App Engine
This is Rietveld 408576698