Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3995)

Unified Diff: cc/tiles/tile_manager.cc

Issue 1803863003: cc: Remove some unnecessary const scoped_refptr&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/tiles/tile_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/tile_manager.cc
diff --git a/cc/tiles/tile_manager.cc b/cc/tiles/tile_manager.cc
index cd9af2482fb61e73e9fe31ba109569f9f94d4ef5..e950484d16003df35daf1d6aad08dec849c8f4d7 100644
--- a/cc/tiles/tile_manager.cc
+++ b/cc/tiles/tile_manager.cc
@@ -268,17 +268,19 @@ scoped_ptr<TileManager> TileManager::Create(
base::SequencedTaskRunner* task_runner,
size_t scheduled_raster_task_limit,
bool use_partial_raster) {
+ // TODO(vmpstr): |task_runner| is a raw pointer that is implicitly converted
+ // into a scoped_refptr. Figure out whether to plumb a ref pointer or whether
+ // tile manager can have a non-owning pointer and fix.
return make_scoped_ptr(new TileManager(
client, task_runner, scheduled_raster_task_limit, use_partial_raster));
}
-TileManager::TileManager(
- TileManagerClient* client,
- const scoped_refptr<base::SequencedTaskRunner>& task_runner,
- size_t scheduled_raster_task_limit,
- bool use_partial_raster)
+TileManager::TileManager(TileManagerClient* client,
+ scoped_refptr<base::SequencedTaskRunner> task_runner,
+ size_t scheduled_raster_task_limit,
+ bool use_partial_raster)
: client_(client),
- task_runner_(task_runner),
+ task_runner_(std::move(task_runner)),
resource_pool_(nullptr),
tile_task_runner_(nullptr),
scheduled_raster_task_limit_(scheduled_raster_task_limit),
« no previous file with comments | « cc/tiles/tile_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698