Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3332)

Unified Diff: cc/layers/layer_proto_converter.h

Issue 1803863003: cc: Remove some unnecessary const scoped_refptr&. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer_proto_converter.cc » ('j') | cc/layers/layer_proto_converter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_proto_converter.h
diff --git a/cc/layers/layer_proto_converter.h b/cc/layers/layer_proto_converter.h
index 94afcb91f7bfd82fa29ed7849efd69bba3c5c0c3..10e5d4e7890b1a8d079ff2bd4ec3999d45b10b0d 100644
--- a/cc/layers/layer_proto_converter.h
+++ b/cc/layers/layer_proto_converter.h
@@ -67,9 +67,9 @@ class CC_EXPORT LayerProtoConverter {
proto::LayerUpdate* layer_update);
using LayerIdMap = std::unordered_map<int, scoped_refptr<Layer>>;
danakj 2016/03/16 00:08:15 Does this need to be refptrs? If so the FindAllLay
vmpstr 2016/03/16 16:38:37 I think it makes sense for the map to be owning, s
danakj 2016/03/16 18:04:31 OK. BTW if blink no longer changes cc during pain
- // Start at |layer| and recursively add |layer| and all its children and
- // special layers to |layer_id_map|.
- static void RecursivelyFindAllLayers(const scoped_refptr<Layer>& layer,
+ // Start at |root_layer| and recursively add the layer and all its children
+ // and special layers to |layer_id_map|.
+ static void RecursivelyFindAllLayers(Layer* root_layer,
LayerIdMap* layer_id_map);
};
« no previous file with comments | « no previous file | cc/layers/layer_proto_converter.cc » ('j') | cc/layers/layer_proto_converter.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698