Move LiveNodeListBase code out of HTMLCollection.cpp

Move LiveNodeListBase code out of HTMLCollection.cpp

Move LiveNodeListBase code out of HTMLCollection.cpp and into
LiveNodeListBase.h.

R=adamk@chromium.org, adamk, esprehn

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167847

[adamk, 2014-02-25 22:05:40]

lgtm

https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
File Source/core/dom/LiveNodeListBase.h (right):

https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
Source/core/dom/LiveNodeListBase.h:148: inline Element*
LiveNodeListBase::iterateForPreviousNode(const Collection& collection, Node*
current)
I take it you're hoping the ALWAYS_INLINE wasn't necessary? Seems reasonable for
a first cut. Is there a reason to still mark this as "inline" (my memory of when
that matters for templated functions is a bit shaky today)?

[Inactive, 2014-02-25 22:14:53]

On 2014/02/25 22:05:40, adamk wrote:
> lgtm
> 
>
https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
> File Source/core/dom/LiveNodeListBase.h (right):
> 
>
https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
> Source/core/dom/LiveNodeListBase.h:148: inline Element*
> LiveNodeListBase::iterateForPreviousNode(const Collection& collection, Node*
> current)
> I take it you're hoping the ALWAYS_INLINE wasn't necessary? Seems reasonable
for
> a first cut. Is there a reason to still mark this as "inline" (my memory of
when
> that matters for templated functions is a bit shaky today)?

Yes, I am hoping the ALWAYS_INLINE is not needed so I used the less aggressive
inline instead. I did not dare remove the inline completely though. However, now
that I googled it, it seems inline is not needed for a templated function like
this. I will remove it and make sure it works.

[Inactive, 2014-02-25 22:32:45]

https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
File Source/core/dom/LiveNodeListBase.h (right):

https://codereview.chromium.org/180383002/diff/1/Source/core/dom/LiveNodeList...
Source/core/dom/LiveNodeListBase.h:148: inline Element*
LiveNodeListBase::iterateForPreviousNode(const Collection& collection, Node*
current)
On 2014/02/25 22:05:40, adamk wrote:
> I take it you're hoping the ALWAYS_INLINE wasn't necessary? Seems reasonable
for
> a first cut. Is there a reason to still mark this as "inline" (my memory of
when
> that matters for templated functions is a bit shaky today)?

I dropped the inline as it shouldn't be needed for such templated function and
there is no linking error.

[Inactive, 2014-02-25 22:40:47]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-02-25 22:46:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180383002/20001

[commit-bot: I haz the power, 2014-02-25 23:14:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180383002/20001

[commit-bot: I haz the power, 2014-02-25 23:28:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/180383002/20001

[Inactive, 2014-02-26 03:38:48]

Committed patchset #3 manually as r167847 (presubmit successful).