Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1803783002: Reland of "Finish conversion to sk_sp<SkShader> (patchset #2 id:20001 of https://codereview.chromiu… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of "Finish conversion to sk_sp<SkShader> (patchset #2 id:20001 of https://codereview.chromium.org/1803763002/ )" This reverts commit 106e10ddff5d473dc81dd1ce8ade615585ea609b. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1803783002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot TBR= Committed: https://skia.googlesource.com/skia/+/c6f28f7f0e788dc43cad4494e277e9ad7b958b6e

Patch Set 1 #

Patch Set 2 : update cmake example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -117 lines) Patch
M bench/AlternatingColorPatternBench.cpp View 5 chunks +8 lines, -13 lines 0 comments Download
M bench/ColorCubeBench.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M bench/GameBench.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M bench/GradientBench.cpp View 5 chunks +41 lines, -47 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M bench/PatchBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/PatchGridBench.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M bench/RectBench.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M bench/TileBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M cmake/example.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
M example/HelloWorld.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M samplecode/SampleClamp.cpp View 1 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803783002/20001
4 years, 9 months ago (2016-03-14 19:05:38 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 19:22:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c6f28f7f0e788dc43cad4494e277e9ad7b958b6e

Powered by Google App Engine
This is Rietveld 408576698