Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 180373003: [polymer] switch comment style (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -901 lines) Patch
M pkg/polymer/example/canonicalization/test/deploy2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/deploy3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/deploy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dev2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dev3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dev_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dir/deploy2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dir/deploy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dir/dev2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization/test/dir/dev_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization2/test/bad_lib_import2_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization2/test/bad_lib_import_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization3/test/bad_lib_import2_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/canonicalization3/test/bad_lib_import_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/example/component/news/test/news_index_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/polymer/lib/builder.dart View 6 chunks +161 lines, -176 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 1 chunk +16 lines, -18 lines 0 comments Download
M pkg/polymer/lib/init.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M pkg/polymer/lib/polymer.dart View 1 chunk +33 lines, -35 lines 0 comments Download
M pkg/polymer/lib/src/boot.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/build_filter.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/polymer/lib/src/build/code_extractor.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 9 chunks +39 lines, -55 lines 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 8 chunks +35 lines, -44 lines 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 11 chunks +34 lines, -52 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/polymer/lib/src/build/runner.dart View 15 chunks +46 lines, -74 lines 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 7 chunks +21 lines, -29 lines 2 comments Download
M pkg/polymer/lib/src/build/utils.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 12 chunks +42 lines, -60 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 33 chunks +144 lines, -199 lines 0 comments Download
M pkg/polymer/lib/src/job.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 6 chunks +42 lines, -57 lines 0 comments Download
M pkg/polymer/lib/transformer.dart View 2 chunks +10 lines, -12 lines 0 comments Download
M pkg/polymer/test/build/common.dart View 2 chunks +6 lines, -12 lines 0 comments Download
M pkg/polymer/test/build/utils_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/line_doc_comments.dart View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
6 years, 10 months ago (2014-02-25 22:53:22 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/180373003/diff/1/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (right): https://codereview.chromium.org/180373003/diff/1/pkg/polymer/lib/src/build/script_compactor.dart#newcode213 pkg/polymer/lib/src/build/script_compactor.dart:213: /// a method initializer for [function]. if you ...
6 years, 10 months ago (2014-02-25 23:32:44 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/180373003/diff/1/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (right): https://codereview.chromium.org/180373003/diff/1/pkg/polymer/lib/src/build/script_compactor.dart#newcode213 pkg/polymer/lib/src/build/script_compactor.dart:213: /// a method initializer for [function]. On 2014/02/25 23:32:45, ...
6 years, 10 months ago (2014-02-25 23:42:41 UTC) #3
Jennifer Messerly
6 years, 10 months ago (2014-02-25 23:44:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r33046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698