Source/bindings/v8/WrapperTypeInfo.h - Issue 180363004: Convert DOMWrapperMap to use PersistentValueMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/WrapperTypeInfo.h

Issue 180363004: Convert DOMWrapperMap to use PersistentValueMap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: adapt 2nd rounf of feedback on v8.h Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/WrapperTypeInfo.h

diff --git a/Source/bindings/v8/WrapperTypeInfo.h b/Source/bindings/v8/WrapperTypeInfo.h

index 73c872da875c500a873e311f55472c199f09e34d..a1e3690fa3f619430d2cde67d67c836f59624e59 100644

--- a/Source/bindings/v8/WrapperTypeInfo.h

+++ b/Source/bindings/v8/WrapperTypeInfo.h

@@ -213,7 +213,7 @@ namespace WebCore {

Dependent, Independent

};

- void configureWrapper(v8::Persistent<v8::Object>* wrapper) const

+ void configureWrapper(v8::PersistentBase<v8::Object>* wrapper) const

{

wrapper->SetWrapperClassId(classId);

if (lifetime == Independent)