Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: net/base/connection_type_histograms.cc

Issue 18036: Push MD5 certificate histograms to UMA.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/connection_type_histograms.cc
===================================================================
--- net/base/connection_type_histograms.cc (revision 7967)
+++ net/base/connection_type_histograms.cc (working copy)
@@ -17,21 +17,26 @@
// of that type during that session. In the second group (counter2), each
// counter is the number of connections of that type the user has seen during
// that session.
+//
+// Each histogram has an unused bucket at the end to allow seamless future
+// expansion.
void UpdateConnectionTypeHistograms(ConnectionType type) {
static bool had_connection_type[NUM_OF_CONNECTION_TYPES];
static LinearHistogram counter1(L"Net.HadConnectionType",
- 1, NUM_OF_CONNECTION_TYPES - 1,
- NUM_OF_CONNECTION_TYPES);
+ 1, NUM_OF_CONNECTION_TYPES,
+ NUM_OF_CONNECTION_TYPES + 1);
static LinearHistogram counter2(L"Net.ConnectionTypeCount",
- 1, NUM_OF_CONNECTION_TYPES - 1,
- NUM_OF_CONNECTION_TYPES);
+ 1, NUM_OF_CONNECTION_TYPES,
+ NUM_OF_CONNECTION_TYPES + 1);
if (type >= 0 && type < NUM_OF_CONNECTION_TYPES) {
if (!had_connection_type[type]) {
had_connection_type[type] = true;
+ counter1.SetFlags(kUmaTargetedHistogramFlag);
counter1.Add(type);
}
}
+ counter2.SetFlags(kUmaTargetedHistogramFlag);
counter2.Add(type);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698