Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1803453003: [wasm] Int64Lowering of Word64Popcnt. (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@arm-shr
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Int64Lowering of Word64Popcnt. Word64Popcnt is lowered to Word32Popcnt(low-word) + Word32Popcnt(high_word). Since the optional Word64Popcnt operator does not exist on 32 bit platforms, I introduced a new operator "Word64PopcntPlaceholder" which is generated in the WasmCompiler and then lowered in the Int64Lowering. R=titzer@chromium.org Committed: https://crrev.com/2e6f3e86078ac28e9974d62f0afc4085a32a2cb0 Cr-Commit-Position: refs/heads/master@{#34777}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment added. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -11 lines) Patch
M src/compiler/int64-lowering.cc View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 2 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 9 months ago (2016-03-14 08:05:40 UTC) #1
titzer
lgtm https://codereview.chromium.org/1803453003/diff/1/src/compiler/machine-operator.cc File src/compiler/machine-operator.cc (right): https://codereview.chromium.org/1803453003/diff/1/src/compiler/machine-operator.cc#newcode474 src/compiler/machine-operator.cc:474: const Operator* MachineOperatorBuilder::Word64PopcntPlaceholder() { Please leave a comment ...
4 years, 9 months ago (2016-03-14 09:50:31 UTC) #2
ahaas
On 2016/03/14 at 09:50:31, titzer wrote: > lgtm > > https://codereview.chromium.org/1803453003/diff/1/src/compiler/machine-operator.cc > File src/compiler/machine-operator.cc (right): ...
4 years, 9 months ago (2016-03-14 12:33:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803453003/40001
4 years, 9 months ago (2016-03-15 10:35:00 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-15 10:42:14 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 10:42:15 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e6f3e86078ac28e9974d62f0afc4085a32a2cb0
Cr-Commit-Position: refs/heads/master@{#34777}

Powered by Google App Engine
This is Rietveld 408576698