Issue 18034028: SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18034028: SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask. (Closed)

Created:
7 years, 5 months ago by f(malita)

Modified:
7 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

SkObjectParser::SaveFlagsToString() should handle SaveFlags as a bitmask. Test one SaveFlags bit at a time instead of exploring the whole value space. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10014

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	src/utils/debugger/SkObjectParser.cpp	View		1 chunk	+14 lines, -18 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/18034028/1

7 years, 5 months ago (2013-07-11 15:20:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/18034028/1

7 years, 5 months ago (2013-07-11 16:06:41 UTC) #4

f(malita)

7 years, 5 months ago (2013-07-11 16:26:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r10014 (presubmit successful).