Chromium Code Reviews

Issue 18034024: Remove the compiled_transitions flag and cleanup the unused code. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne, mvstanton, Dmitry Lomov (no reviews), danno
CC:
v8-dev
Visibility:
Public.

Description

The compiled_transitions flag was enabled for quite some time now and seems to work out quite well, so time has come to remove the obsolete code paths and remove the unused methods. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15922

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Stats (+24 lines, -493 lines)
M src/arm/ic-arm.cc View 1 chunk +0 lines, -45 lines 0 comments
M src/arm/lithium-arm.h View 1 chunk +2 lines, -5 lines 0 comments
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -12 lines 0 comments
M src/arm/lithium-codegen-arm.cc View 2 chunks +1 line, -23 lines 0 comments
M src/builtins.h View 1 chunk +0 lines, -4 lines 0 comments
M src/builtins.cc View 1 chunk +0 lines, -9 lines 0 comments
M src/code-stubs.h View 1 chunk +0 lines, -42 lines 0 comments
M src/code-stubs.cc View 1 chunk +0 lines, -38 lines 0 comments
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments
M src/ia32/ic-ia32.cc View 1 chunk +0 lines, -55 lines 0 comments
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +1 line, -23 lines 0 comments
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -11 lines 0 comments
M src/ic.h View 1 chunk +0 lines, -2 lines 0 comments
M src/mips/ic-mips.cc View 1 chunk +0 lines, -45 lines 0 comments
M src/mips/lithium-codegen-mips.cc View 2 chunks +1 line, -23 lines 0 comments
M src/mips/lithium-mips.h View 1 chunk +2 lines, -5 lines 0 comments
M src/mips/lithium-mips.cc View 1 chunk +3 lines, -12 lines 0 comments
M src/runtime.h View 1 chunk +0 lines, -2 lines 0 comments
M src/runtime.cc View 1 chunk +0 lines, -34 lines 0 comments
M src/stub-cache.cc View 1 chunk +5 lines, -15 lines 0 comments
M src/x64/ic-x64.cc View 1 chunk +0 lines, -49 lines 0 comments
M src/x64/lithium-codegen-x64.cc View 2 chunks +1 line, -23 lines 0 comments
M src/x64/lithium-x64.cc View 1 chunk +1 line, -10 lines 0 comments
M test/mjsunit/elements-transition-and-store.js View 1 chunk +1 line, -1 line 0 comments
M test/mjsunit/generated-transition-stub.js View 1 chunk +1 line, -1 line 0 comments
M test/mjsunit/transition-elements-kind.js View 1 chunk +1 line, -2 lines 0 comments

Messages

Total messages: 9 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-11 12:43:21 UTC) #1
mvstanton
I think I'd turn on the flag first, verify that chrome stability is good and ...
7 years, 5 months ago (2013-07-11 13:11:20 UTC) #2
Benedikt Meurer
On 2013/07/11 13:11:20, mvstanton wrote: > I think I'd turn on the flag first, verify ...
7 years, 5 months ago (2013-07-11 13:33:25 UTC) #3
danno
Yes, experience has shown that you should leave all the old code in for the ...
7 years, 5 months ago (2013-07-11 13:56:35 UTC) #4
Benedikt Meurer
On 2013/07/11 13:56:35, danno wrote: > Yes, experience has shown that you should leave all ...
7 years, 5 months ago (2013-07-11 13:57:34 UTC) #5
Benedikt Meurer
REBASE
7 years, 4 months ago (2013-07-29 07:35:46 UTC) #6
Benedikt Meurer
compiled_transitions was enabled by default for some time now. PTAL
7 years, 4 months ago (2013-07-29 07:38:29 UTC) #7
mvstanton
This is neat. lgtm. :)
7 years, 4 months ago (2013-07-29 07:56:08 UTC) #8
Benedikt Meurer
7 years, 4 months ago (2013-07-29 09:12:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r15922 (presubmit successful).

Powered by Google App Engine