Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 18034: Recreate the skia image decoder from the undecoded data bits passed down, whe... (Closed)

Created:
11 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
brettw, Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Recreate the skia image decoder from the undecoded data bits passed down, when the image source is cleared. This fixes bug http://code.google.com/p/chromium/issues/detail?id=6259, which occurs when a custom cursor is created by webkit after the webkit cache prune operation has evicted the decoded frames from the image. The fix is on the same lines as the coregraphics implementation of the image source. Bug=6259 R=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8034

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/WebCore/platform/graphics/skia/ImageSourceSkia.cpp View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ananta
11 years, 11 months ago (2009-01-14 00:38:17 UTC) #1
brettw
http://codereview.chromium.org/18034/diff/1/2 File third_party/WebKit/WebCore/platform/graphics/skia/ImageSourceSkia.cpp (right): http://codereview.chromium.org/18034/diff/1/2#newcode103 Line 103: // TODO(darin): Figure out what to do with ...
11 years, 11 months ago (2009-01-14 00:39:38 UTC) #2
ananta
http://codereview.chromium.org/18034/diff/1/2 File third_party/WebKit/WebCore/platform/graphics/skia/ImageSourceSkia.cpp (right): http://codereview.chromium.org/18034/diff/1/2#newcode103 Line 103: // TODO(darin): Figure out what to do with ...
11 years, 11 months ago (2009-01-14 00:44:11 UTC) #3
brettw
LGTM
11 years, 11 months ago (2009-01-14 00:44:59 UTC) #4
Peter Kasting
Please rewrite this function to just be a copy of the Cairo version. I wrote ...
11 years, 11 months ago (2009-01-14 00:49:26 UTC) #5
ananta
On 2009/01/14 00:49:26, pkasting wrote: > Please rewrite this function to just be a copy ...
11 years, 11 months ago (2009-01-14 00:57:00 UTC) #6
Peter Kasting
LGTM with nit http://codereview.chromium.org/18034/diff/207/208 File third_party/WebKit/WebCore/platform/graphics/skia/ImageSourceSkia.cpp (right): http://codereview.chromium.org/18034/diff/207/208#newcode111 Line 111: Nit: No blank line here ...
11 years, 11 months ago (2009-01-14 00:58:38 UTC) #7
ananta
On 2009/01/14 00:58:38, pkasting wrote: > LGTM with nit > > http://codereview.chromium.org/18034/diff/207/208 > File third_party/WebKit/WebCore/platform/graphics/skia/ImageSourceSkia.cpp ...
11 years, 11 months ago (2009-01-14 01:08:49 UTC) #8
Peter Kasting
11 years, 11 months ago (2009-01-14 07:07:03 UTC) #9
Again, LGTM

Powered by Google App Engine
This is Rietveld 408576698